* [PATCH] Remove unused and probably incorrect macro TYPE_FN_FIELDS
@ 2014-04-16 12:11 Siva Chandra
2014-04-16 15:36 ` Joel Brobecker
0 siblings, 1 reply; 3+ messages in thread
From: Siva Chandra @ 2014-04-16 12:11 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
Probably an obvious commit, but I might not be aware of any historical
decision around this.
Patch is attached. Tested by building on x86_64 GNU/Linux.
2014-04-16 Siva Chandra Reddy <sivachandra@google.com>
* gdbtypes.h: Remove definition of the macro TYPE_FN_FIELDS.
[-- Attachment #2: remove_type_fn_fields.txt --]
[-- Type: text/plain, Size: 663 bytes --]
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index e91ab97..e63d255 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -1205,7 +1205,6 @@ extern void allocate_gnat_aux_type (struct type *);
#define TYPE_VPTR_BASETYPE(thistype) TYPE_MAIN_TYPE(thistype)->vptr_basetype
#define TYPE_DOMAIN_TYPE(thistype) TYPE_MAIN_TYPE(thistype)->vptr_basetype
#define TYPE_VPTR_FIELDNO(thistype) TYPE_MAIN_TYPE(thistype)->vptr_fieldno
-#define TYPE_FN_FIELDS(thistype) TYPE_CPLUS_SPECIFIC(thistype)->fn_fields
#define TYPE_NFN_FIELDS(thistype) TYPE_CPLUS_SPECIFIC(thistype)->nfn_fields
#define TYPE_SPECIFIC_FIELD(thistype) \
TYPE_MAIN_TYPE(thistype)->type_specific_field
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Remove unused and probably incorrect macro TYPE_FN_FIELDS
2014-04-16 12:11 [PATCH] Remove unused and probably incorrect macro TYPE_FN_FIELDS Siva Chandra
@ 2014-04-16 15:36 ` Joel Brobecker
2014-04-16 22:45 ` Siva Chandra
0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2014-04-16 15:36 UTC (permalink / raw)
To: Siva Chandra; +Cc: gdb-patches
> 2014-04-16 Siva Chandra Reddy <sivachandra@google.com>
>
> * gdbtypes.h: Remove definition of the macro TYPE_FN_FIELDS.
I'm not aware of the history either, but it's really easy to put back
should there be any reason to, so go ahead and push.
Thanks!
> diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
> index e91ab97..e63d255 100644
> --- a/gdb/gdbtypes.h
> +++ b/gdb/gdbtypes.h
> @@ -1205,7 +1205,6 @@ extern void allocate_gnat_aux_type (struct type *);
> #define TYPE_VPTR_BASETYPE(thistype) TYPE_MAIN_TYPE(thistype)->vptr_basetype
> #define TYPE_DOMAIN_TYPE(thistype) TYPE_MAIN_TYPE(thistype)->vptr_basetype
> #define TYPE_VPTR_FIELDNO(thistype) TYPE_MAIN_TYPE(thistype)->vptr_fieldno
> -#define TYPE_FN_FIELDS(thistype) TYPE_CPLUS_SPECIFIC(thistype)->fn_fields
> #define TYPE_NFN_FIELDS(thistype) TYPE_CPLUS_SPECIFIC(thistype)->nfn_fields
> #define TYPE_SPECIFIC_FIELD(thistype) \
> TYPE_MAIN_TYPE(thistype)->type_specific_field
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove unused and probably incorrect macro TYPE_FN_FIELDS
2014-04-16 15:36 ` Joel Brobecker
@ 2014-04-16 22:45 ` Siva Chandra
0 siblings, 0 replies; 3+ messages in thread
From: Siva Chandra @ 2014-04-16 22:45 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches
On Wed, Apr 16, 2014 at 8:36 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> 2014-04-16 Siva Chandra Reddy <sivachandra@google.com>
>>
>> * gdbtypes.h: Remove definition of the macro TYPE_FN_FIELDS.
>
> I'm not aware of the history either, but it's really easy to put back
> should there be any reason to, so go ahead and push.
Done, but with two pushes as I missed adding the ChangeLog entry in
the first push:
8000c58e455259951daa4370631aa616b367d1a7 and
7a23c5494be60600d34527f5adeaa2a34b85fdb6
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-16 22:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-16 12:11 [PATCH] Remove unused and probably incorrect macro TYPE_FN_FIELDS Siva Chandra
2014-04-16 15:36 ` Joel Brobecker
2014-04-16 22:45 ` Siva Chandra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox