From: Jim Wilson <jimw@sifive.com>
To: John Baldwin <jhb@freebsd.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] RISC-V: Don't allow unaligned breakpoints.
Date: Thu, 01 Nov 2018 23:37:00 -0000 [thread overview]
Message-ID: <CAFyWVaaEkK8LPCnQB70E7GD_bWkKQCTQ5s1qX9jqgJqNJaKoZA@mail.gmail.com> (raw)
In-Reply-To: <e4fa69a6-aa80-b7ad-7ec6-62ec80888720@FreeBSD.org>
On Thu, Nov 1, 2018 at 3:05 PM John Baldwin <jhb@freebsd.org> wrote:
> This looks good to me. Not sure if you want to explicitly add something to
> the comment that an unaligned PC is only valid if C is supported, so we
> know C.EBREAK is safe to use with an unaligned PC?
That seemed obvious to me, but yes it is probably better to spell it
out in a comment. I'll add that to the patch.
Jim
next prev parent reply other threads:[~2018-11-01 23:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 21:41 Jim Wilson
2018-11-01 22:05 ` John Baldwin
2018-11-01 23:37 ` Jim Wilson [this message]
2018-11-01 23:46 ` Andrew Burgess
2018-11-02 0:27 ` Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyWVaaEkK8LPCnQB70E7GD_bWkKQCTQ5s1qX9jqgJqNJaKoZA@mail.gmail.com \
--to=jimw@sifive.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox