From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120761 invoked by alias); 1 Nov 2018 23:37:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120747 invoked by uid 89); 1 Nov 2018 23:37:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ua1-f66.google.com Received: from mail-ua1-f66.google.com (HELO mail-ua1-f66.google.com) (209.85.222.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Nov 2018 23:37:03 +0000 Received: by mail-ua1-f66.google.com with SMTP id i30so58143uae.11 for ; Thu, 01 Nov 2018 16:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yvqLoI8xuF1h/X1qTZJzUIJXyczta5QVbTj2NTTI3Lo=; b=V9h1hwZhXQ7Gj+wAovji01opyGcjXjBN08zu7Lq95N++cIc47g7OawOGxGP30DV0My tWVTQUFVTG2RBzny/Vu/Gn0UNeO/16FctRq4EP0FxDk4lr4HdFCdUPd4oHY6LGB9y17j zSSjADV7B0taHrlo9cVfZXtbfSZWmvI92Hnj0l6caxu6c6cwl6ttDyF2CNOFOq95x8Rl h3WxUuGd83mlpSmjALEKsxVsCCMwJcDpFe0YO/o6fwwQ5w3A5ewbCNZcVKq8OHqDEp2I QfmH3s18FOiDQjB8nMKKhbvYSB7wjmGeDLssO1Gwe3XXBOCj6hbitZDBzc4Ks0CBh/3i Vjxw== MIME-Version: 1.0 References: <20181101214139.27196-1-jimw@sifive.com> In-Reply-To: From: Jim Wilson Date: Thu, 01 Nov 2018 23:37:00 -0000 Message-ID: Subject: Re: [PATCH] RISC-V: Don't allow unaligned breakpoints. To: John Baldwin Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-11/txt/msg00016.txt.bz2 On Thu, Nov 1, 2018 at 3:05 PM John Baldwin wrote: > This looks good to me. Not sure if you want to explicitly add something to > the comment that an unaligned PC is only valid if C is supported, so we > know C.EBREAK is safe to use with an unaligned PC? That seemed obvious to me, but yes it is probably better to spell it out in a comment. I'll add that to the patch. Jim