Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix accessing a function's fields (parameters) from Python (PR 18073)
Date: Thu, 22 Oct 2015 10:54:00 -0000	[thread overview]
Message-ID: <CAFXXi0=DZ=9cL89Oh6DKQHyHX0qO5G_M5MSc5fb3qM5sbFgnDQ@mail.gmail.com> (raw)
In-Reply-To: <20151021194718.GD3971@adacore.com>

On 21 October 2015 at 15:47, Joel Brobecker <brobecker@adacore.com> wrote:
> The patch looks good to me, although I am not one of the main Python
> maintainers. Normally, I'd ask the author to wait an extra week for
> additional comments, but since you've already waited a month, I think
> it's only fair to give you the go ahead to push. If there are comments
> with your code, we can handle them then.
>
> Thanks also adding the tests. You probably know this, but this is
> always appreciated.
>
> Thanks!

Thanks, pushed!


      reply	other threads:[~2015-10-21 20:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28  4:44 Simon Marchi
2015-10-06 16:43 ` Simon Marchi
2015-10-22 10:06   ` Joel Brobecker
2015-10-22 10:54     ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFXXi0=DZ=9cL89Oh6DKQHyHX0qO5G_M5MSc5fb3qM5sbFgnDQ@mail.gmail.com' \
    --to=simon.marchi@polymtl.ca \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox