From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72340 invoked by alias); 21 Oct 2015 20:00:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72259 invoked by uid 89); 21 Oct 2015 20:00:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f43.google.com Received: from mail-qg0-f43.google.com (HELO mail-qg0-f43.google.com) (209.85.192.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 21 Oct 2015 20:00:13 +0000 Received: by qgem9 with SMTP id m9so37749344qge.1 for ; Wed, 21 Oct 2015 13:00:10 -0700 (PDT) X-Received: by 10.140.95.53 with SMTP id h50mr13659919qge.8.1445457610812; Wed, 21 Oct 2015 13:00:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.75.66 with HTTP; Wed, 21 Oct 2015 12:59:41 -0700 (PDT) In-Reply-To: <20151021194718.GD3971@adacore.com> References: <1443415430-31110-1-git-send-email-simon.marchi@polymtl.ca> <20151021194718.GD3971@adacore.com> From: Simon Marchi Date: Thu, 22 Oct 2015 10:54:00 -0000 Message-ID: Subject: Re: [PATCH] Fix accessing a function's fields (parameters) from Python (PR 18073) To: Joel Brobecker Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-10/txt/msg00433.txt.bz2 On 21 October 2015 at 15:47, Joel Brobecker wrote: > The patch looks good to me, although I am not one of the main Python > maintainers. Normally, I'd ask the author to wait an extra week for > additional comments, but since you've already waited a month, I think > it's only fair to give you the go ahead to push. If there are comments > with your code, we can handle them then. > > Thanks also adding the tests. You probably know this, but this is > always appreciated. > > Thanks! Thanks, pushed!