Re: [PATCH] Fix alignment of disassemble /r

[Daniel Gutson <daniel.gutson@tallertechnologies.com>]

On Sun, Apr 20, 2014 at 9:54 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 04/18/2014 01:27 AM, Daniel Gutson wrote:
>> I already considered this, but thought that it would be going to be
>> rejected due to be too much non-performant. Wouldn't each pass
>> translate in a lot of MI messaging in a case of a remote server? And,
>
> If you meant "rsp packets" rather than "MI messaging",

Yes, my bad, sorry.

we don't worry
> about the performance much here.  disassemble uses code cache
> (target_read_code) to read instructions from remote server and the
> following read to the same area will hit the cache.
>
>> what about screen paginig? I shouldn't iterate over all the range, but
>> the screen height range only.
>
> What is the reason do you think we shouldn't iterator over all the
> range?  IMO， screen height and alignment are orthogonal.

Suppose your function takes two screens of disassembly.
Then  suppose that the instructions that fit in the first screen take
N bytes at most,
and those of the second takes N+k. If I ignore screen paging, I would
be aligning
the first screen to N+k too, whereas those k are just useless space.
It's a minor and cosmetic concern, but I'd like to get it right and
pretty in one shot :)

   Daniel.

>
> --
> Yao (齐尧)



-- 

Daniel F. Gutson
Chief Engineering Officer, SPD


San Lorenzo 47, 3rd Floor, Office 5

Córdoba, Argentina


Phone: +54 351 4217888 / +54 351 4218211

Skype: dgutson