Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Daniel Gutson <daniel.gutson@tallertechnologies.com>,
	Doug Evans	<dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix alignment of disassemble /r
Date: Mon, 21 Apr 2014 00:56:00 -0000	[thread overview]
Message-ID: <53546C38.2000901@codesourcery.com> (raw)
In-Reply-To: <CAF5HaEUjLYqQdgvrwEdUKBJFFeCaaZ8BQQQTSJz1RMo_VEJdUA@mail.gmail.com>

On 04/18/2014 01:27 AM, Daniel Gutson wrote:
> I already considered this, but thought that it would be going to be
> rejected due to be too much non-performant. Wouldn't each pass
> translate in a lot of MI messaging in a case of a remote server? And,

If you meant "rsp packets" rather than "MI messaging", we don't worry
about the performance much here.  disassemble uses code cache
(target_read_code) to read instructions from remote server and the
following read to the same area will hit the cache.

> what about screen paginig? I shouldn't iterate over all the range, but
> the screen height range only.

What is the reason do you think we shouldn't iterator over all the
range?  IMO, screen height and alignment are orthogonal.

-- 
Yao (齐尧)


  parent reply	other threads:[~2014-04-21  0:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-11 22:24 Daniel Gutson
2014-04-16 12:20 ` Daniel Gutson
2014-04-17  1:09 ` Yao Qi
2014-04-17 14:37   ` Daniel Gutson
2014-04-17 16:27     ` Doug Evans
2014-04-17 17:27       ` Daniel Gutson
2014-04-17 18:19         ` Doug Evans
2014-04-21  0:56         ` Yao Qi [this message]
2014-04-21 16:00           ` Daniel Gutson
2014-04-22 12:14             ` Daniel Gutson
2016-03-04 20:41               ` Daniel Gutson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53546C38.2000901@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=daniel.gutson@tallertechnologies.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox