From: David Michael <fedora.dm0@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: bug-hurd@gnu.org, gdb-patches@sourceware.org
Subject: Re: [RFC] GDB Hurd Fixes
Date: Fri, 20 Sep 2013 15:17:00 -0000 [thread overview]
Message-ID: <CAEvUa7mgjOosxVP13VDqcaFP=5Nt66N7XEttr6oGHso9q0VfSw@mail.gmail.com> (raw)
In-Reply-To: <523C0B99.7080109@redhat.com>
Hi,
On Fri, Sep 20, 2013 at 4:47 AM, Pedro Alves <palves@redhat.com> wrote:
> On 09/20/2013 01:43 AM, David Michael wrote:
>> (Copying gdb-patches this time.)
> But, we're missing all the context on the gdb-patches@ side.
Sorry about that--here's an explanation of the problems in GDB's build
process with current Hurd:
First, mig has stopped using the "auto" keyword in its output.[1]
Without that keyword, gdb/reply_mig_hack.awk fails to match a
necessary pattern and outputs a bad gdb/process_reply_S.c file. The
first change I made adds a new pattern to the script in addition to
the old one, so it should work with both old and new mig binaries.
Next, new function definitions were added (then renamed) in
<hurd/process_reply.defs>.[2] In the generated
gdb/process_reply_S.raw, some of the new functions match patterns in
gdb/reply_mig_hack.awk in a different order than expected, producing
bad output again. The second change I made to the script ensures a
necessary definition is found before writing output. (It may be
preferable to add a "parse_phase = 6" instead.)
Also because of [2], linking fails due to missing some new functions
in gdb/process_reply_S.c. I just extended the way other unused
functions from process_reply.defs were handled previously in
gdb/gnu-nat.c.
Thanks.
David
[1] http://git.savannah.gnu.org/cgit/hurd/mig.git/commit/?id=b53836447df7230cd5665a7ccabd2a6e1a6607e5
[2] http://git.savannah.gnu.org/cgit/hurd/hurd.git/commit/?id=e19cc6184fb99394845d56e6e915fea9805e5c28
next prev parent reply other threads:[~2013-09-20 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 0:43 David Michael
2013-09-20 8:47 ` Pedro Alves
2013-09-20 8:55 ` Thomas Schwinge
2013-09-20 15:17 ` David Michael [this message]
2014-01-06 16:56 ` Thomas Schwinge
2014-01-06 17:25 ` Pedro Alves
2014-05-06 3:49 ` Samuel Bronson
2014-05-06 6:42 ` Thomas Schwinge
2016-01-12 12:01 ` Hurd: Make gdb/reply_mig_hack.awk script compatible to "mawk" (was: [RFC] GDB Hurd Fixes) Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEvUa7mgjOosxVP13VDqcaFP=5Nt66N7XEttr6oGHso9q0VfSw@mail.gmail.com' \
--to=fedora.dm0@gmail.com \
--cc=bug-hurd@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox