From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4913 invoked by alias); 20 Sep 2013 15:17:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4900 invoked by uid 89); 20 Sep 2013 15:17:10 -0000 Received: from mail-pa0-f52.google.com (HELO mail-pa0-f52.google.com) (209.85.220.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 20 Sep 2013 15:17:10 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KHOP_THREADED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f52.google.com Received: by mail-pa0-f52.google.com with SMTP id kq13so827684pab.25 for ; Fri, 20 Sep 2013 08:17:08 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.66.163.2 with SMTP id ye2mr9624893pab.168.1379690228407; Fri, 20 Sep 2013 08:17:08 -0700 (PDT) Received: by 10.70.103.74 with HTTP; Fri, 20 Sep 2013 08:17:08 -0700 (PDT) In-Reply-To: <523C0B99.7080109@redhat.com> References: <523C0B99.7080109@redhat.com> Date: Fri, 20 Sep 2013 15:17:00 -0000 Message-ID: Subject: Re: [RFC] GDB Hurd Fixes From: David Michael To: Pedro Alves Cc: bug-hurd@gnu.org, gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2013-09/txt/msg00766.txt.bz2 Hi, On Fri, Sep 20, 2013 at 4:47 AM, Pedro Alves wrote: > On 09/20/2013 01:43 AM, David Michael wrote: >> (Copying gdb-patches this time.) > But, we're missing all the context on the gdb-patches@ side. Sorry about that--here's an explanation of the problems in GDB's build process with current Hurd: First, mig has stopped using the "auto" keyword in its output.[1] Without that keyword, gdb/reply_mig_hack.awk fails to match a necessary pattern and outputs a bad gdb/process_reply_S.c file. The first change I made adds a new pattern to the script in addition to the old one, so it should work with both old and new mig binaries. Next, new function definitions were added (then renamed) in .[2] In the generated gdb/process_reply_S.raw, some of the new functions match patterns in gdb/reply_mig_hack.awk in a different order than expected, producing bad output again. The second change I made to the script ensures a necessary definition is found before writing output. (It may be preferable to add a "parse_phase = 6" instead.) Also because of [2], linking fails due to missing some new functions in gdb/process_reply_S.c. I just extended the way other unused functions from process_reply.defs were handled previously in gdb/gnu-nat.c. Thanks. David [1] http://git.savannah.gnu.org/cgit/hurd/mig.git/commit/?id=b53836447df7230cd5665a7ccabd2a6e1a6607e5 [2] http://git.savannah.gnu.org/cgit/hurd/hurd.git/commit/?id=e19cc6184fb99394845d56e6e915fea9805e5c28