From: David Blaikie <dblaikie@gmail.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Eric Christopher <echristo@gmail.com>
Subject: Re: [patch] explicitly specify -std=gnu89 for gdb.cp/inline-break.exp
Date: Sat, 12 Apr 2014 00:40:00 -0000 [thread overview]
Message-ID: <CAENS6EsG9mqkFkW=vbR-C+whJ_dB80goV2fEefO=3=hH_t2yYw@mail.gmail.com> (raw)
In-Reply-To: <CADPb22Q02WZGHif_tLv1vZRA48MhXjGY+ZUdhvNUryODf=5qxw@mail.gmail.com>
On Fri, Apr 11, 2014 at 5:18 PM, Doug Evans <dje@google.com> wrote:
> On Fri, Apr 11, 2014 at 4:58 PM, David Blaikie <dblaikie@gmail.com> wrote:
>> This test is intending to use gnu style inline rather than the
>> standard c99 inline semantics. Clang defaults to c99 and the test
>> breaks for this (and other - there's an inlining debug info quality
>> bug here too - I'll file a bug and kfail the remaining failures in a
>> separate patch) reason.
>
> LGTM, but add a comment in the code explaining why the gnu89 is there.
Thanks. Added a comment and committed in
f180a1fb463a6a9ab4a883374120d16770486914.
next prev parent reply other threads:[~2014-04-12 0:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 23:58 David Blaikie
2014-04-12 0:18 ` Doug Evans
2014-04-12 0:40 ` David Blaikie [this message]
2014-04-12 2:59 ` Andrew Pinski
2014-04-13 7:08 ` David Blaikie
2014-05-01 10:52 ` Pedro Alves
2014-05-30 11:25 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAENS6EsG9mqkFkW=vbR-C+whJ_dB80goV2fEefO=3=hH_t2yYw@mail.gmail.com' \
--to=dblaikie@gmail.com \
--cc=dje@google.com \
--cc=echristo@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox