From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-111742-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7112 invoked by alias); 12 Apr 2014 00:40:17 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 7096 invoked by uid 89); 12 Apr 2014 00:40:16 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-qg0-f49.google.com
Received: from mail-qg0-f49.google.com (HELO mail-qg0-f49.google.com) (209.85.192.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 12 Apr 2014 00:40:14 +0000
Received: by mail-qg0-f49.google.com with SMTP id j107so478964qga.22        for <gdb-patches@sourceware.org>; Fri, 11 Apr 2014 17:40:12 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.224.166.129 with SMTP id m1mr2960240qay.58.1397263212795; Fri, 11 Apr 2014 17:40:12 -0700 (PDT)
Received: by 10.140.30.74 with HTTP; Fri, 11 Apr 2014 17:40:12 -0700 (PDT)
In-Reply-To: <CADPb22Q02WZGHif_tLv1vZRA48MhXjGY+ZUdhvNUryODf=5qxw@mail.gmail.com>
References: <CAENS6EsUSQTajixKzmStvX9KrG-8SaTA=YVO=6MFMpY35Um9FQ@mail.gmail.com>	<CADPb22Q02WZGHif_tLv1vZRA48MhXjGY+ZUdhvNUryODf=5qxw@mail.gmail.com>
Date: Sat, 12 Apr 2014 00:40:00 -0000
Message-ID: <CAENS6EsG9mqkFkW=vbR-C+whJ_dB80goV2fEefO=3=hH_t2yYw@mail.gmail.com>
Subject: Re: [patch] explicitly specify -std=gnu89 for gdb.cp/inline-break.exp
From: David Blaikie <dblaikie@gmail.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>, Eric Christopher <echristo@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
X-SW-Source: 2014-04/txt/msg00232.txt.bz2

On Fri, Apr 11, 2014 at 5:18 PM, Doug Evans <dje@google.com> wrote:
> On Fri, Apr 11, 2014 at 4:58 PM, David Blaikie <dblaikie@gmail.com> wrote:
>> This test is intending to use gnu style inline rather than the
>> standard c99 inline semantics. Clang defaults to c99 and the test
>> breaks for this (and other - there's an inlining debug info quality
>> bug here too - I'll file a bug and kfail the remaining failures in a
>> separate patch) reason.
>
> LGTM, but add a comment in the code explaining why the gnu89 is there.

Thanks. Added a comment and committed in
f180a1fb463a6a9ab4a883374120d16770486914.