From: Doug Evans <dje@google.com>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] When can we remove Sun-specific stabs support? (when will it be ok to delete partial_symtab.section_offsets?)
Date: Thu, 07 May 2015 23:04:00 -0000 [thread overview]
Message-ID: <CADPb22TyGuXwRom2FSv-46Ac6-qDzrVGOFoMXewCpoBGJ1ropw@mail.gmail.com> (raw)
In-Reply-To: <CADPb22QOG+A-kRaiY1PvRU8bnEw-L2EHzb5eOiSiX2GAQZ50GA@mail.gmail.com>
On Thu, May 7, 2015 at 3:52 PM, Doug Evans <dje@google.com> wrote:
> ...
> IIUC, and assuming I'm not missing anything,
> this has been broken since at least gdb 7.0 (I didn't
> check back any further).
> The code was a little different back then, but the free_elfinfo
> cleanup was still done before building psymtabs.
>
> Sufficient motivation for deleting this code now?
I'm guessing this is the patch, from 2003.
2003-02-20 Daniel Jacobowitz <drow@mvista.com>
* coffread.c (coff_symfile_read): Clean up minimal symbols earlier.
* dbxread.c (elfstab_build_psymtabs): Don't call
install_minimal_symbols.
(stabsect_build_psymtabs): Likewise.
* elfread.c (elf_symfile_read): Call install_minimal_symbols
earlier.
* somread.c (som_symfile_read): Call install_minimal_symbols
and do_cleanups earlier.
* nlmread.c (nlm_symfile_read): Likewise.
* mdebugread.c (elfmdebug_build_psymtabs): Call
install_minimal_symbols and make appropriate cleanups.
[there's a typo in the date of the c/l entry, which I fixed after cut-n-pasting]
So, assuming I'm not missing anything, we haven't supported
this hack for Sun stabs since 2003.
Patch to delete it completely to follow,
unless there's a REALLY good reason to keep it.
next prev parent reply other threads:[~2015-05-07 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 21:21 Doug Evans
2015-05-07 22:52 ` Doug Evans
2015-05-07 23:04 ` Doug Evans [this message]
2015-05-08 10:47 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22TyGuXwRom2FSv-46Ac6-qDzrVGOFoMXewCpoBGJ1ropw@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox