From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4841 invoked by alias); 7 May 2015 23:04:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4832 invoked by uid 89); 7 May 2015 23:04:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f169.google.com Received: from mail-ob0-f169.google.com (HELO mail-ob0-f169.google.com) (209.85.214.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 07 May 2015 23:04:49 +0000 Received: by obbkp3 with SMTP id kp3so43276847obb.3 for ; Thu, 07 May 2015 16:04:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=Enh41+2x2eM/u+BWBT8jQy8jIV0zz5YPQppvGaJ79Xo=; b=PbZor2TN/iUTy+qiTsO/lEMRH2xuq11FSJ1iqe9llYoSjMntFuk0rYaicqVsaEy6r1 7ilFfJgUa71PyfSRxTn9YlFzHIKLfRQp1zTdF4wOJg2ffn/PUopLwCQMNIJZNsX3Hk7K 7j+ZDXbeV4ITFkqmPxxP0VvjG8fwPjhEyYDeJfxliFKPhawSkW6ASrB6RKnCUHkX2zDk 64AFu81r7a5fuiIAahpWwX/rMZu8G+qi95bCaJVFT9QjLBRKaKHNulQ9+kcWkq7zzSzy 2/sZ03dmjtJIbyoEBpMk4DIZEu0hudBCvpE9TxXv120UMXTJoGIB4tLfb1btop8h6xxJ Of3w== X-Gm-Message-State: ALoCoQnkaT78RsB5eOlPf+bLW+ggCbGHM9OmxqgubXqK1OSTfd4Fa44kfcQDx3+f/dUPZGKVuebA MIME-Version: 1.0 X-Received: by 10.202.88.66 with SMTP id m63mr761038oib.47.1431039887775; Thu, 07 May 2015 16:04:47 -0700 (PDT) Received: by 10.182.89.99 with HTTP; Thu, 7 May 2015 16:04:47 -0700 (PDT) In-Reply-To: References: <90e6ba6e87129285600515847ec6@google.com> Date: Thu, 07 May 2015 23:04:00 -0000 Message-ID: Subject: Re: [RFC] When can we remove Sun-specific stabs support? (when will it be ok to delete partial_symtab.section_offsets?) From: Doug Evans To: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00171.txt.bz2 On Thu, May 7, 2015 at 3:52 PM, Doug Evans wrote: > ... > IIUC, and assuming I'm not missing anything, > this has been broken since at least gdb 7.0 (I didn't > check back any further). > The code was a little different back then, but the free_elfinfo > cleanup was still done before building psymtabs. > > Sufficient motivation for deleting this code now? I'm guessing this is the patch, from 2003. 2003-02-20 Daniel Jacobowitz * coffread.c (coff_symfile_read): Clean up minimal symbols earlier. * dbxread.c (elfstab_build_psymtabs): Don't call install_minimal_symbols. (stabsect_build_psymtabs): Likewise. * elfread.c (elf_symfile_read): Call install_minimal_symbols earlier. * somread.c (som_symfile_read): Call install_minimal_symbols and do_cleanups earlier. * nlmread.c (nlm_symfile_read): Likewise. * mdebugread.c (elfmdebug_build_psymtabs): Call install_minimal_symbols and make appropriate cleanups. [there's a typo in the date of the c/l entry, which I fixed after cut-n-pasting] So, assuming I'm not missing anything, we haven't supported this hack for Sun stabs since 2003. Patch to delete it completely to follow, unless there's a REALLY good reason to keep it.