From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] Accelerate filenames matching
Date: Tue, 12 Mar 2013 17:48:00 -0000 [thread overview]
Message-ID: <CADPb22TxdJmb=tmbvBjz=9wzaFQjKFka8j3DbJU6TJ=2PX25SQ@mail.gmail.com> (raw)
In-Reply-To: <20130312132640.GA21810@host2.jankratochvil.net>
On Tue, Mar 12, 2013 at 6:26 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> Hi,
>
> I have read Doug's IRC line:
> xdje: In dw2_map_symtabs_matching_filename, in the case where compare_filenames_for_search succeeds, is there a point to falling through and trying again with the real path if dw2_map_expand_apply returns 0?
>
> So here is the fix. It could call the callback multiple times which may be
> considered a bug (I have not checked if it may be a problem for any of the
> callbacks).
>
> No regressions on {x86_64,x86_64-m32,i686}-fedora19pre-linux-gnu.
>
>
> Thanks,
> Jan
>
>
> gdb/
> 2013-03-12 Doug Evans <dje@google.com>
> Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * dwarf2read.c (dw2_map_symtabs_matching_filename): Put continue after
> any successful compare_filenames_for_search or FILENAME_CMP.
> * psymtab.c (partial_map_symtabs_matching_filename): Likewise.
> * symtab.c (iterate_over_some_symtabs): Likewise.
If there are no regressions, 'tis fine with me.
Thanks!
next prev parent reply other threads:[~2013-03-12 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 13:26 Jan Kratochvil
2013-03-12 15:19 ` Joel Brobecker
2013-03-12 15:29 ` Jan Kratochvil
2013-03-12 17:48 ` Doug Evans [this message]
2013-03-14 16:37 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22TxdJmb=tmbvBjz=9wzaFQjKFka8j3DbJU6TJ=2PX25SQ@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox