From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99456-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17421 invoked by alias); 12 Mar 2013 17:48:24 -0000
Received: (qmail 17409 invoked by uid 22791); 12 Mar 2013 17:48:22 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail-ve0-f173.google.com (HELO mail-ve0-f173.google.com) (209.85.128.173)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 17:48:16 +0000
Received: by mail-ve0-f173.google.com with SMTP id oz10so97571veb.4        for <gdb-patches@sourceware.org>; Tue, 12 Mar 2013 10:48:15 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20120113;        h=mime-version:x-received:in-reply-to:references:date:message-id         :subject:from:to:cc:content-type:x-gm-message-state;        bh=DvfSbar0YlcF6sdwsqeHcwM248KqSCwYOA+yxcKHljQ=;        b=KS9WT7mZJQG8/VN8dXnFO3snrqKTREso3WcG2l8Tf0c7QOAoqg3l5UJc7rwA0s4wZ1         yYoC2GjSbXLnf7J3eB/xH2Dm/7jroW8PzSETZjnzoPX3XmPVI+M7++Id3/3QlcnnEQ1i         aEVuj+yVuu0ULfMlBtV9vmjO0HJHTWiLbGouOBY5fW86yVRAySUWLRnO3qTkrGvTJX2z         DWA6AFgtPHB9PMzI22YZy/o5TK+/gmXFMbz73o7R1IgcklaFai0DgKYfI20dQoE4wA0h         NFD/LrX4FT/QMjirFma2o4yM+AnINOSCHp90AEuqlDhqzG1dPQNfIcU00G4zr7+s3OWF         d5gA==
MIME-Version: 1.0
X-Received: by 10.52.36.194 with SMTP id s2mr6075470vdj.119.1363110494569; Tue, 12 Mar 2013 10:48:14 -0700 (PDT)
Received: by 10.221.1.71 with HTTP; Tue, 12 Mar 2013 10:48:14 -0700 (PDT)
In-Reply-To: <20130312132640.GA21810@host2.jankratochvil.net>
References: <20130312132640.GA21810@host2.jankratochvil.net>
Date: Tue, 12 Mar 2013 17:48:00 -0000
Message-ID: <CADPb22TxdJmb=tmbvBjz=9wzaFQjKFka8j3DbJU6TJ=2PX25SQ@mail.gmail.com>
Subject: Re: [patch] Accelerate filenames matching
From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Gm-Message-State: ALoCoQmqSocG9BezoR2vrKB83ayL3thY2dHkcvWt2cwncGIWGH3Uuske1w5ZFmAeME4wHHpzLKzKL2Ro+pnMprxMsX0x09Bk9vuu9PNXqkqs5b+wceOH6aAnAd+ysUFCovhWfIbHQKVwr2SifAsMSH12/RGQnsjPc17vXK44H7NztAbF+qKeGeFztNxWW3ru2Yt36LWsqRsRC3OO2qpqOGnTw8ZKlWy8gg==
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00532.txt.bz2

On Tue, Mar 12, 2013 at 6:26 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> Hi,
>
> I have read Doug's IRC line:
>         xdje: In dw2_map_symtabs_matching_filename, in the case where compare_filenames_for_search succeeds, is there a point to falling through and trying again with the real path if dw2_map_expand_apply returns 0?
>
> So here is the fix.  It could call the callback multiple times which may be
> considered a bug (I have not checked if it may be a problem for any of the
> callbacks).
>
> No regressions on {x86_64,x86_64-m32,i686}-fedora19pre-linux-gnu.
>
>
> Thanks,
> Jan
>
>
> gdb/
> 2013-03-12  Doug Evans  <dje@google.com>
>             Jan Kratochvil  <jan.kratochvil@redhat.com>
>
>         * dwarf2read.c (dw2_map_symtabs_matching_filename): Put continue after
>         any successful compare_filenames_for_search or FILENAME_CMP.
>         * psymtab.c (partial_map_symtabs_matching_filename): Likewise.
>         * symtab.c (iterate_over_some_symtabs): Likewise.

If there are no regressions, 'tis fine with me.
Thanks!