From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [patch#2 3/6] set auto-load local-gdbinit warn-and-*
Date: Thu, 05 Apr 2012 16:28:00 -0000 [thread overview]
Message-ID: <CADPb22TwB9tBASJU4D=widAHDZOfXc6UWXkfS0k3DbrMT+nKVQ@mail.gmail.com> (raw)
In-Reply-To: <20120403183311.GB13483@host2.jankratochvil.net>
On Tue, Apr 3, 2012 at 11:33 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
>> > gdb-scripts: Canned sequences of commands auto-loading is on.
>> > libthread-db: Inferior specific libthread_db auto-loading is on.
>> > -local-gdbinit: Current directory .gdbinit script auto-loading is on.
>> > +local-gdbinit: Current directory .gdbinit script auto-loading is yes.
>>
>> Why "yes"?
>
> parse_binary_operation accepts any of 'on', '1', 'yes' or 'enable' (and sure
> off/0/no/disable). It then displays the boolean only as "on" and "off".
>
> Somehow it seems more appropriate for these auto-loading settings to use
> yes/no instead of on/off. This is also why I use yes/no in the documentation.
> When I added the warning option I had to choose only one pair, therefore
> I chose yes/no. But this means the default displayed boolean values are new
> yes/no (and not on/off). It also means it no longer accepts the alternative
> words on/1/enable (and off/0/disable); but that is not a real regression when
> the setting never existed before this patchset.
"on" reads much better to me.
> There are two possibilities:
> * Introduce new option some "set local-gdbinit-warning <boolean>" as
> suggested by Doug IIUC and technically keep everything boolean.
For completeness sake,
I was suggesting making the option more general, applying to more to
more than just local-gdbinit (assuming more applications were readily
available).
> * Switch the words used in documentation from yes/no to on/off, therefore
> also make the switch on/off/warn-and-on/warn-and-off.
next prev parent reply other threads:[~2012-04-05 16:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 9:13 Jan Kratochvil
2012-03-29 20:58 ` Doug Evans
2012-03-30 6:28 ` Eli Zaretskii
2012-03-30 6:33 ` Doug Evans
2012-03-30 6:45 ` Jan Kratochvil
2012-03-30 18:08 ` suspend: " Jan Kratochvil
2012-03-30 7:26 ` Eli Zaretskii
2012-04-02 20:31 ` [doc patch] objfile -> @var{objfile} [Re: [patch#2 3/6] set auto-load local-gdbinit warn-and-*] Jan Kratochvil
2012-04-02 21:10 ` Eli Zaretskii
2012-04-02 21:13 ` Jan Kratochvil
2012-04-02 21:19 ` Eli Zaretskii
2012-04-03 18:33 ` [patch#2 3/6] set auto-load local-gdbinit warn-and-* Jan Kratochvil
2012-04-05 16:15 ` Eli Zaretskii
2012-04-05 21:00 ` Jan Kratochvil
2012-04-05 16:28 ` Doug Evans [this message]
2012-04-05 16:53 ` Jan Kratochvil
2012-04-05 17:03 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22TwB9tBASJU4D=widAHDZOfXc6UWXkfS0k3DbrMT+nKVQ@mail.gmail.com' \
--to=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox