From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5602 invoked by alias); 5 Apr 2012 16:28:09 -0000 Received: (qmail 5531 invoked by uid 22791); 5 Apr 2012 16:28:05 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-gx0-f169.google.com (HELO mail-gx0-f169.google.com) (209.85.161.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Apr 2012 16:27:52 +0000 Received: by ggeq1 with SMTP id q1so954854gge.0 for ; Thu, 05 Apr 2012 09:27:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=7xOlOhhnDW84QZJly8hMm/Vq9IFCf2mSaQr/YDQgvzM=; b=J7m6JSPhvOdYw1F+4ObMp3KRSmHBJhrUYTHUqZPjUb8qBuMvRh21Hdy9z1qsGS0SdD LrLno6jMOMfewJ+xTKVT2VhXu1FRjBd5fbY4IkTCjuY4rydkGpiS8y108BS0pPlKSmUp KQ/OnQcGauwi47T9aLvsE+t5axL4l2hum743Mk9nJP0raOL7ErpjG00WB3memwg7DDhA XPhEG4qDPyWtYC7e8oE5s8WpsIg6HTyuwtdUU3P/gh7OauslC6qpvYjAzYovEpAGCCj2 9CpFliWuNlArs1gcA/Z/YsqHW5NiI3WEdWDQuf60tzmlPHdbUs6BK6M1RQ1kOsAtEJiQ AWrQ== Received: by 10.60.20.3 with SMTP id j3mr4952487oee.43.1333643271726; Thu, 05 Apr 2012 09:27:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.20.3 with SMTP id j3mr4952470oee.43.1333643271627; Thu, 05 Apr 2012 09:27:51 -0700 (PDT) Received: by 10.182.66.14 with HTTP; Thu, 5 Apr 2012 09:27:51 -0700 (PDT) In-Reply-To: <20120403183311.GB13483@host2.jankratochvil.net> References: <20120329091258.GD25449@host2.jankratochvil.net> <83hax61rey.fsf@gnu.org> <20120403183311.GB13483@host2.jankratochvil.net> Date: Thu, 05 Apr 2012 16:28:00 -0000 Message-ID: Subject: Re: [patch#2 3/6] set auto-load local-gdbinit warn-and-* From: Doug Evans To: Jan Kratochvil Cc: Eli Zaretskii , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQlICnYlJqc0s788pNmqVd+T05L1arSWiRKdShP6o+Pt63TK5vqLQgQ8fOXvs85tsWyrKi8Wa9ZXHEs24RaB7mYtsim3bUoCCb+EhODoI/QyTF8ta34oQE3LdwJVOWm849UAUAR5xqcGTYnJk/H+MYQqVyVR4A== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00071.txt.bz2 On Tue, Apr 3, 2012 at 11:33 AM, Jan Kratochvil wrote: >> > =A0gdb-scripts: =A0Canned sequences of commands auto-loading is on. >> > =A0libthread-db: =A0Inferior specific libthread_db auto-loading is on. >> > -local-gdbinit: =A0Current directory .gdbinit script auto-loading is o= n. >> > +local-gdbinit: =A0Current directory .gdbinit script auto-loading is y= es. >> >> Why "yes"? > > parse_binary_operation accepts any of 'on', '1', 'yes' or 'enable' (and s= ure > off/0/no/disable). =A0It then displays the boolean only as "on" and "off". > > Somehow it seems more appropriate for these auto-loading settings to use > yes/no instead of on/off. =A0This is also why I use yes/no in the documen= tation. > When I added the warning option I had to choose only one pair, therefore > I chose yes/no. =A0But this means the default displayed boolean values ar= e new > yes/no (and not on/off). =A0It also means it no longer accepts the altern= ative > words on/1/enable (and off/0/disable); but that is not a real regression = when > the setting never existed before this patchset. "on" reads much better to me. > There are two possibilities: > =A0* Introduce new option some "set local-gdbinit-warning " as > =A0 suggested by Doug IIUC and technically keep everything boolean. For completeness sake, I was suggesting making the option more general, applying to more to more than just local-gdbinit (assuming more applications were readily available). > =A0* Switch the words used in documentation from yes/no to on/off, theref= ore > =A0 also make the switch on/off/warn-and-on/warn-and-off.