From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 06/15] Write status to CTF and read.
Date: Fri, 29 Mar 2013 16:47:00 -0000 [thread overview]
Message-ID: <CADPb22TijufzqFtguSG7ijh5x7_97RxFDSqKnfEUWd-0+sv97w@mail.gmail.com> (raw)
In-Reply-To: <5155415C.4030309@codesourcery.com>
On Fri, Mar 29, 2013 at 12:23 AM, Yao Qi <yao@codesourcery.com> wrote:
> On 03/15/2013 02:06 AM, Doug Evans wrote:
>> > +#define SET_INT32_FIELD(EVENT, SCOPE, VAR, FIELD) \
>> > + VAR->FIELD = (int) bt_ctf_get_int64 (bt_ctf_get_field (EVENT, \
>> > + SCOPE, \
>> > + #FIELD))
>>
>> Macros like this should be in a do { } while (0).
>> do { \
>> ...; \
>> } while (0)
>>
>
> Do we really need do/while loop for this single-line macro?
Always IMO.
>> Plus wrap params in parens (except #FIELD of course).
>>
>
> Of course.
Look at it as wrapping the statement in a do/while is like wrapping
the params in parens. :-)
next prev parent reply other threads:[~2013-03-29 15:50 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 3:48 [PATCH v3 00/15] CTF Support Yao Qi
2013-03-09 3:49 ` [PATCH v3 13/15] Test on saving tracepoint defs Yao Qi
2013-03-12 20:10 ` Tom Tromey
2013-03-13 9:48 ` Yao Qi
2013-03-13 14:58 ` Tom Tromey
2013-03-09 3:49 ` [PATCH v3 06/15] Write status to CTF and read Yao Qi
2013-03-12 19:31 ` Tom Tromey
2013-03-14 18:06 ` Doug Evans
2013-03-29 14:46 ` Yao Qi
2013-03-29 16:47 ` Doug Evans [this message]
2013-03-09 3:49 ` [PATCH v3 09/15] Check the tstatus output on tfile target Yao Qi
2013-03-12 19:45 ` Tom Tromey
2013-03-09 3:49 ` [PATCH v3 08/15] Write 'stop_desc' of trace status to tfile Yao Qi
2013-03-12 19:15 ` Tom Tromey
2013-03-09 3:49 ` [PATCH v3 07/15] Write trace notes and username into tfile Yao Qi
2013-03-12 19:35 ` Tom Tromey
2013-03-09 3:49 ` [PATCH v3 01/15] Refactor 'tsave' Yao Qi
2013-03-12 18:30 ` Tom Tromey
2013-03-13 10:33 ` Yao Qi
2013-03-13 19:26 ` Tom Tromey
2013-03-14 9:17 ` Yao Qi
2013-03-09 3:49 ` [PATCH v3 11/15] Write tsv definition in CTF and read Yao Qi
2013-03-12 19:56 ` Tom Tromey
2013-03-09 3:49 ` [PATCH v3 14/15] Test on saving tracepoint defs: CTF Yao Qi
2013-03-12 20:23 ` Tom Tromey
2013-03-13 9:55 ` Yao Qi
2013-03-13 15:49 ` Tom Tromey
2013-03-09 3:49 ` [PATCH v3 15/15] MAINTAINERS Yao Qi
2013-03-09 3:49 ` [PATCH v3 05/15] ctf test: report.exp Yao Qi
2013-03-12 19:25 ` Tom Tromey
2013-03-09 3:49 ` [PATCH v3 03/15] Read CTF by the ctf target Yao Qi
2013-03-13 20:09 ` Tom Tromey
2013-03-14 13:23 ` Yao Qi
2013-03-14 14:59 ` Tom Tromey
2013-03-14 16:57 ` Doug Evans
2013-03-14 17:39 ` Doug Evans
2013-03-25 13:33 ` Yao Qi
2013-03-25 17:14 ` Doug Evans
2013-03-26 16:16 ` Yao Qi
2013-03-29 17:56 ` Doug Evans
2013-04-08 14:19 ` Yao Qi
2013-04-08 21:48 ` Doug Evans
2013-04-09 15:23 ` Yao Qi
2013-04-09 18:41 ` Doug Evans
2013-03-09 3:49 ` [PATCH v3 04/15] ctf doc and NEWS Yao Qi
2013-03-09 3:49 ` [PATCH v3 12/15] Write tracepoint definition in CTF and read Yao Qi
2013-03-12 20:02 ` Tom Tromey
2013-03-14 18:34 ` Doug Evans
2013-03-09 3:49 ` [PATCH v3 10/15] tstatus.exp: ctf Yao Qi
2013-03-12 19:48 ` Tom Tromey
2013-03-09 3:49 ` [PATCH v3 02/15] Save trace into CTF format Yao Qi
2013-03-12 18:49 ` Tom Tromey
2013-03-13 10:33 ` Yao Qi
2013-03-13 19:30 ` Tom Tromey
2013-03-14 17:49 ` Doug Evans
2013-04-10 19:16 ` [PATCH v3 00/15] CTF Support Yao Qi
2013-04-11 22:59 ` [patch] Regenerate config.in [Re: [PATCH v3 00/15] CTF Support] Jan Kratochvil
2013-04-12 22:27 ` [commit] " Jan Kratochvil
2014-08-04 18:59 ` Incorrect placement of babeltrace gdb/NEWS item " Jan Kratochvil
2014-08-06 1:30 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22TijufzqFtguSG7ijh5x7_97RxFDSqKnfEUWd-0+sv97w@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox