From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29713 invoked by alias); 29 Mar 2013 15:50:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29697 invoked by uid 89); 29 Mar 2013 15:50:12 -0000 X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mail-vc0-f173.google.com (HELO mail-vc0-f173.google.com) (209.85.220.173) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 29 Mar 2013 15:50:10 +0000 Received: by mail-vc0-f173.google.com with SMTP id gd11so605483vcb.18 for ; Fri, 29 Mar 2013 08:50:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=Xt2MOmZlYWT8ZthI8UHfgb2Iau7Ozl/3BH2AWWKIjJQ=; b=fIztcMgCD8aeHMeaNVGi0L+YVWH7tf97hShn4pGXQmO/EFqLvBY4DfK3qjSgpRRzMa vXUC00uk5eGtXwGfHbWLKe9AdkN0H6Bt3dgFQ/m1ToRjZGYsOlyr8+s61qLUjNSKcMtY /c5pp8cSL5ON6IGP4QsrDLN/RT4z6LAfoQvh8thwxyWV4P4WEI83/aBahfpcHcO6Btth 32LNt+Pk/8/23zWczsMWrj+d9ciuzTvrlxqIendou+SzWXMKtir0d5+Lf1Jf7qJ2vKNU UtdC3evgrN+yDd2OL5/W3UHyXVsSVJJyv2LtM07kR0ByYmMlExIxvdUwxVfuTtt8J+nQ 1/cQ== MIME-Version: 1.0 X-Received: by 10.52.28.173 with SMTP id c13mr1828705vdh.96.1364572208130; Fri, 29 Mar 2013 08:50:08 -0700 (PDT) Received: by 10.220.117.67 with HTTP; Fri, 29 Mar 2013 08:50:08 -0700 (PDT) In-Reply-To: <5155415C.4030309@codesourcery.com> References: <1362800844-27940-1-git-send-email-yao@codesourcery.com> <1362800844-27940-7-git-send-email-yao@codesourcery.com> <20802.4537.197713.506858@ruffy2.mtv.corp.google.com> <5155415C.4030309@codesourcery.com> Date: Fri, 29 Mar 2013 16:47:00 -0000 Message-ID: Subject: Re: [PATCH v3 06/15] Write status to CTF and read. From: Doug Evans To: Yao Qi Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlVh3lXknU3JlSBQLhN92qV2RBqlV7BqXVonri0848XXhXvcqioliR3CcdHjxmMZwLbVem1pjvz+szSh2MBbt9sLKjiQymO6B9DQ88MdIPp33VJYq8v9Ugo64eXZIx5On7GeEZ4kXEXXG2Z7Malgp29DafI/ba8ru0OUewgqsDU5JdHd5QvjKcXtMtINHNYWEgwTdgdAMf2gCIvQV7iW0KZbpCDmA== X-SW-Source: 2013-03/txt/msg01111.txt.bz2 On Fri, Mar 29, 2013 at 12:23 AM, Yao Qi wrote: > On 03/15/2013 02:06 AM, Doug Evans wrote: >> > +#define SET_INT32_FIELD(EVENT, SCOPE, VAR, FIELD) \ >> > + VAR->FIELD = (int) bt_ctf_get_int64 (bt_ctf_get_field (EVENT, \ >> > + SCOPE, \ >> > + #FIELD)) >> >> Macros like this should be in a do { } while (0). >> do { \ >> ...; \ >> } while (0) >> > > Do we really need do/while loop for this single-line macro? Always IMO. >> Plus wrap params in parens (except #FIELD of course). >> > > Of course. Look at it as wrapping the statement in a do/while is like wrapping the params in parens. :-)