From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] While processing a struct die, store the method's address in its fn_field
Date: Wed, 26 Nov 2014 05:05:00 -0000 [thread overview]
Message-ID: <CADPb22Tg29wxVEhnEBw+Hh9Asr3UhyNhns+ucZuum4Vvn5o==A@mail.gmail.com> (raw)
In-Reply-To: <CAGyQ6gxMbvXB-fLDiEvWLHhvr-3tgVwBMWZg6UgnWnUC143TTg@mail.gmail.com>
On Tue, Nov 25, 2014 at 8:46 PM, Siva Chandra <sivachandra@google.com> wrote:
> On Tue, Nov 25, 2014 at 8:36 PM, Doug Evans <dje@google.com> wrote:
>> Hi.
>> While going through this is occurs to me: Do we *need* an assembler
>> testcase here?
>> If we're just testing lambda hand-callability, it would be preferable
>> to just have a .cc test.
>
> I preferred an assembler testcase because the problem the patch is
> trying to solve does not occur if Clang is the compiler.
GDB's debug info readers are sometimes a pain to work with because
they have to handle different compilers, and sometimes compiler bugs,
but in general we only go to assembler if there's something specific
in the assembler we need. Here the fact that the .cc fails with gcc
is enough I think. [assember tests bring their own pain, and are not
to be added lightly]
next prev parent reply other threads:[~2014-11-26 5:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 15:55 Siva Chandra
2014-11-24 20:22 ` Doug Evans
2014-11-24 20:28 ` Doug Evans
2014-11-26 4:36 ` Doug Evans
2014-11-26 4:46 ` Siva Chandra
2014-11-26 5:05 ` Doug Evans [this message]
2014-11-25 15:00 ` Siva Chandra
2014-11-25 22:10 ` Doug Evans
2014-11-25 23:37 ` Siva Chandra
2014-11-26 3:22 ` Doug Evans
2014-11-26 3:58 ` Siva Chandra
2014-11-26 5:19 ` Doug Evans
2014-11-26 7:31 ` Siva Chandra
2014-11-26 21:11 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22Tg29wxVEhnEBw+Hh9Asr3UhyNhns+ucZuum4Vvn5o==A@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox