From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8902 invoked by alias); 26 Nov 2014 05:05:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8893 invoked by uid 89); 26 Nov 2014 05:05:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vc0-f177.google.com Received: from mail-vc0-f177.google.com (HELO mail-vc0-f177.google.com) (209.85.220.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 26 Nov 2014 05:05:10 +0000 Received: by mail-vc0-f177.google.com with SMTP id ij19so949620vcb.36 for ; Tue, 25 Nov 2014 21:05:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ex+L4UVp6AkSEdYezxtMHcwvOd8J8esop5W/CaHR3g8=; b=OMiTyR2ZLlH8jcgEKHMRHcl7q23cvHDsWFJIXYEXH90UvhuWmv84lVoggZemxsS38F FGvFB3SKOcRWlRLh8fNT4JqkISp/3+pJRjJfkxQ7Bv7iQHgS5krOViyOYvfwxMXe+J78 oCXw/8OkAr8VSGeWAS9vUykixP84q5MuuHcdxrveKPYgT0VUJ+oORyQNgUkvfJbL3/Q4 p7JL38mfgYVVD0kudbQGIsuYgQSW1Z7Aecu3O3JerGjhyCQ+gFCShlHy58802G3Ed/nV Qi5vWRGutete5m7E6u7QfFdulP3eiNwe9RcsK8PLSCee6lDOOQPuXTNdrLV0NOHluQqM oN5Q== X-Gm-Message-State: ALoCoQkXa5i55GNn/Hb/OCHlUKm2OaQ6bsDVIu47GGdr1sum3fMUXv96cUaFyYjwzxGXw72HJmhg MIME-Version: 1.0 X-Received: by 10.52.184.167 with SMTP id ev7mr14210240vdc.67.1416978308215; Tue, 25 Nov 2014 21:05:08 -0800 (PST) Received: by 10.52.114.101 with HTTP; Tue, 25 Nov 2014 21:05:08 -0800 (PST) In-Reply-To: References: Date: Wed, 26 Nov 2014 05:05:00 -0000 Message-ID: Subject: Re: [RFC] While processing a struct die, store the method's address in its fn_field From: Doug Evans To: Siva Chandra Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00648.txt.bz2 On Tue, Nov 25, 2014 at 8:46 PM, Siva Chandra wrote: > On Tue, Nov 25, 2014 at 8:36 PM, Doug Evans wrote: >> Hi. >> While going through this is occurs to me: Do we *need* an assembler >> testcase here? >> If we're just testing lambda hand-callability, it would be preferable >> to just have a .cc test. > > I preferred an assembler testcase because the problem the patch is > trying to solve does not occur if Clang is the compiler. GDB's debug info readers are sometimes a pain to work with because they have to handle different compilers, and sometimes compiler bugs, but in general we only go to assembler if there's something specific in the assembler we need. Here the fact that the .cc fails with gcc is enough I think. [assember tests bring their own pain, and are not to be added lightly]