From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Siva Chandra <sivachandra@google.com>, gdb-patches@sourceware.org
Subject: Re: [RFC - Python Scripting] Add 'end' attribute to gdb.Symtab_and_line
Date: Fri, 22 Jun 2012 21:12:00 -0000 [thread overview]
Message-ID: <CADPb22TEyfAnF6R0AaRqxZFgPErFB4P4wsE38DPG8eY3f9NvFw@mail.gmail.com> (raw)
In-Reply-To: <87k3yzgtjo.fsf@fleche.redhat.com>
On Fri, Jun 22, 2012 at 10:12 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
>
> Siva> +static PyObject *
> Siva> +salpy_get_last (PyObject *self, void *closure)
> Siva> +{
> Siva> + struct symtab_and_line *sal = NULL;
> Siva> +
> Siva> + SALPY_REQUIRE_VALID (self, sal);
> Siva> +
> Siva> + return gdb_py_long_from_ulongest (sal->end - 1);
>
> It seems that sal->end can be == 0.
> For example I think gdb.decode_line can create sals like this.
> In this case I think "- 1" will yield weird results.
> Perhaps a None return would be better?
Good point. None "works for me".
next prev parent reply other threads:[~2012-06-22 21:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 8:40 Siva Chandra
2012-05-21 16:27 ` Eli Zaretskii
2012-06-01 19:57 ` Siva Chandra
2012-06-11 9:17 ` Siva Chandra
2012-06-11 21:22 ` Doug Evans
2012-06-12 18:41 ` Siva Chandra
2012-06-12 19:43 ` Eli Zaretskii
2012-06-13 7:24 ` Siva Chandra
2012-06-13 15:15 ` Eli Zaretskii
2012-06-13 13:29 ` Siva Chandra
2012-06-13 17:08 ` Doug Evans
2012-06-13 18:15 ` Siva Chandra
2012-06-22 9:21 ` Siva Chandra
2012-06-22 17:12 ` Tom Tromey
2012-06-22 21:12 ` Doug Evans [this message]
2012-06-24 17:03 ` Siva Chandra
2012-06-26 22:12 ` Doug Evans
2012-06-27 0:23 ` Siva Chandra
2012-06-22 17:10 ` Tom Tromey
2012-06-22 18:43 ` Siva Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22TEyfAnF6R0AaRqxZFgPErFB4P4wsE38DPG8eY3f9NvFw@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox