From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92407-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26797 invoked by alias); 22 Jun 2012 21:12:15 -0000
Received: (qmail 26788 invoked by uid 22791); 22 Jun 2012 21:12:14 -0000
X-SWARE-Spam-Status: No, hits=-5.5 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jun 2012 21:12:01 +0000
Received: by vbkv13 with SMTP id v13so1374055vbk.0        for <gdb-patches@sourceware.org>; Fri, 22 Jun 2012 14:12:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20120113;        h=mime-version:in-reply-to:references:date:message-id:subject:from:to         :cc:content-type:content-transfer-encoding:x-system-of-record         :x-gm-message-state;        bh=88q6e9RNPSW0MawyT3JJkj9jsDFHL/EW/WGIYTUcI1w=;        b=ITV271d1BZCYGGo3tQXZn1WDtyQdNQfoiQ07IjPJjeHUrr6wY9/Af6v4nY8FgHZ0sO         WawF0CdAxjibePsNM/XF9xccnWG57ZsWHNOcoT6i0jEGrsWz4AD3kinDQ+vsO38Ac37G         xOab1rHN1H7gamtAbkmZ1O8VXVQxXZxH5aGqIwdnnKHxlhayylFI75Gd/KijC6sk1kZb         qCYl7ZTldFhNP7/KD48g1ogt3CcFhFAbZLz41iJ6TZy1BLR1Pw1S7ej6WM+GuDOGYSUr         QXcIO05VwyulxUI5LbATUbJ2unqnTB3fMTt2GOXGStgrkDqTirqoqdZFK2Rmas/koDmF         mXVA==
Received: by 10.52.33.37 with SMTP id o5mr1481089vdi.86.1340399521095;        Fri, 22 Jun 2012 14:12:01 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.52.33.37 with SMTP id o5mr1481080vdi.86.1340399520995; Fri, 22 Jun 2012 14:12:00 -0700 (PDT)
Received: by 10.52.92.242 with HTTP; Fri, 22 Jun 2012 14:12:00 -0700 (PDT)
In-Reply-To: <87k3yzgtjo.fsf@fleche.redhat.com>
References: <CAGyQ6gw7JP3Mz+nabiTGcnC4oP7d9iQ3W8miHOs3NnDyFqiF0g@mail.gmail.com>	<CADPb22Sacqq3vWoXh0Q9q2fdxZr9WXHPOhvbCUWTDKOwrmNCMA@mail.gmail.com>	<CAGyQ6gwDhacRNuCxvsWRnt7tKDJ2_0iyryw+hdL5rsq+h3MaAA@mail.gmail.com>	<CAGyQ6gwy+cKQ2oGUOfEMSPRx+=Jt4H8zHEH0tbUbywZBR8Ggog@mail.gmail.com>	<CADPb22QCCUPNKHGPTNrAN_ZMynSAKnVxeQVRc-Mdkod6xWO--g@mail.gmail.com>	<CAGyQ6gyr1-X=5d7Gyf2Pb+oazMQmJoatUyEG9OaKzKt0obEqJw@mail.gmail.com>	<87k3yzgtjo.fsf@fleche.redhat.com>
Date: Fri, 22 Jun 2012 21:12:00 -0000
Message-ID: <CADPb22TEyfAnF6R0AaRqxZFgPErFB4P4wsE38DPG8eY3f9NvFw@mail.gmail.com>
Subject: Re: [RFC - Python Scripting] Add 'end' attribute to gdb.Symtab_and_line
From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Siva Chandra <sivachandra@google.com>, gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-Gm-Message-State: ALoCoQkoKy0yD/IYSzBeo2wHp0D2DeTjfR8YleooPz5oP5Bd+yTU1hJKuT95JcebmN5HX8tkaNLFpw5tkztxOqppexXzSXMhbVLtZEfJEgchySy8RbCUdrlfB2dzJptA2bL7reCxekqXH7IAQhsu41SZILiif8qXWYl+jSmbgh2t2wlI3VDgLsHJXCBxsaAyA2LasaHMilgk
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-06/txt/msg00740.txt.bz2

On Fri, Jun 22, 2012 at 10:12 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Siva" =3D=3D Siva Chandra <sivachandra@google.com> writes:
>
> Siva> +static PyObject *
> Siva> +salpy_get_last (PyObject *self, void *closure)
> Siva> +{
> Siva> + =A0struct symtab_and_line *sal =3D NULL;
> Siva> +
> Siva> + =A0SALPY_REQUIRE_VALID (self, sal);
> Siva> +
> Siva> + =A0return gdb_py_long_from_ulongest (sal->end - 1);
>
> It seems that sal->end can be =3D=3D 0.
> For example I think gdb.decode_line can create sals like this.
> In this case I think "- 1" will yield weird results.
> Perhaps a None return would be better?

Good point.  None "works for me".