Re: [PING][PATCH] arch-utils: Make the last endianness actually chosen sticky

[Doug Evans <dje@google.com>]

On Tue, Nov 8, 2016 at 12:45 AM, Maciej W. Rozycki <macro@imgtec.com> wrote:
> On Fri, 14 Oct 2016, Maciej W. Rozycki wrote:
>
>>       gdb/
>>       * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to
>>       the endianness selected.
>>
>>       gdb/testsuite
>>       * gdb.base/endian.exp: New test.
>>       * gdb.base/endian.c: New test source.
>
>  Can I ask for <https://patchwork.sourceware.org/patch/16504/> to be
> reviewed?

Hi.

This is fine with me.
[I can imagine oddities if someone was doing multi-inferior debugging
with different endiannesses, but that's a rare situation, and I don't
think any oddities if they exist are killers.]

I tested it on amd64-linux just as a sanity check.

I think a NEWS entry is required.

I'm kinda thinking an addition to the "Choosing Target Byte Order"
would be nice, but it's not mandatory. [If we do so, I think to do it
right you would have to document a whole lot more than just
this simple addition, and I don't like imposing on you that
burden. If you want to take it on, great of course.
But to me it's not necessary for this patch to go in.]