From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63741 invoked by alias); 8 Nov 2016 22:50:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63718 invoked by uid 89); 8 Nov 2016 22:50:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1157, H*r:10.28.152, Order X-HELO: mail-wm0-f52.google.com Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Nov 2016 22:50:21 +0000 Received: by mail-wm0-f52.google.com with SMTP id p190so275354500wmp.1 for ; Tue, 08 Nov 2016 14:50:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=C1/8Yzm7jhaJnweYGuHS6xD7TTrgafl6RlLO3ZDlpiQ=; b=ZQfqN0iONbA4dOWHE25zg5eJTY7odx2Ga0sRddcQGOCGOQA73nl0WAsmDuO5RGc5CZ hwmy2ecqhBMRmtr4SN7DSa7kXgdClEayOkSgUX7CsOMlZXbIbNVqsXUoa6dnU8Q6871I 599Vpna+Lpahqh5WjeJRmhTw1kUSP4dgDcKwOdUdkWl5CzHutD88Qk7Y/bfSldCX9fp1 0P4DqnDTSoqKKMOQNrl/WxX5YTHzI69zkkjMdNvKHAWM2fNYjbYJqjiTnOMiRtbkLKhm dpYut/jdtH8DzYC1IBiYXTXJHfpaYe27xNL5++ZPjnzubA7mu2MieoJd48CHGBzrf4h4 v8Bw== X-Gm-Message-State: ABUngvd+bybWW+hop0/D1KX4NesO7B/Jwvf2FaA0Ti67XhU3fTI6J0oOB4Dead8JY2i5J2ns6mlfeO3QuTQZdyHE X-Received: by 10.194.201.227 with SMTP id kd3mr15419527wjc.74.1478645419774; Tue, 08 Nov 2016 14:50:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.152.70 with HTTP; Tue, 8 Nov 2016 14:49:39 -0800 (PST) In-Reply-To: References: From: Doug Evans Date: Tue, 08 Nov 2016 22:50:00 -0000 Message-ID: Subject: Re: [PING][PATCH] arch-utils: Make the last endianness actually chosen sticky To: "Maciej W. Rozycki" Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00191.txt.bz2 On Tue, Nov 8, 2016 at 12:45 AM, Maciej W. Rozycki wrote: > On Fri, 14 Oct 2016, Maciej W. Rozycki wrote: > >> gdb/ >> * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to >> the endianness selected. >> >> gdb/testsuite >> * gdb.base/endian.exp: New test. >> * gdb.base/endian.c: New test source. > > Can I ask for to be > reviewed? Hi. This is fine with me. [I can imagine oddities if someone was doing multi-inferior debugging with different endiannesses, but that's a rare situation, and I don't think any oddities if they exist are killers.] I tested it on amd64-linux just as a sanity check. I think a NEWS entry is required. I'm kinda thinking an addition to the "Choosing Target Byte Order" would be nice, but it's not mandatory. [If we do so, I think to do it right you would have to document a whole lot more than just this simple addition, and I don't like imposing on you that burden. If you want to take it on, great of course. But to me it's not necessary for this patch to go in.]