Re: FYI: [python/Ada] gdb.lookup_type fails to looking primitive type

[Doug Evans <dje@google.com>]

On Tue, Jan 13, 2015 at 1:44 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> ...
>> > +proc test_lookup_type { lang type_name } {
>> > +    gdb_test_no_output "set language ${lang}"
>> > +    gdb_test_no_output "python gdb.lookup_type('${type_name}')" \
>> > +        "lookup type ${type_name} using language ${lang}"
>> > +}
>>
>> I wouldn't have expected gdb_test_no_output to work here
>> for python.lookup_type, though I can see that it does.
>> This is no different than "python 1+1": it doesn't print anything either.
>
> And I actually believe that this is the expected behavior of a python
> "script", even if the "script" is passed on the command line. I am
> guessing that you are thinking of the case where you are inside the
> interactive interpreter, in which case, yes, we expect it to print
> the returned value each time. But this is not a test where we use
> the interactive interpreter here, hence I would not expect any output.
> If I wanted some output, I'd have used "print".
>
> As a result, a "clarifying" comment would have actually confused
> things more, IMO, and so I elected to not add one.

Alas I was confused without it. :-)

> Attached is what I ended up checking in:
>
> gdb/ChangeLog:
>
>         * ada-lang.c (ada_lookup_symbol_nonlocal): If name not found
>         in static block, then try searching for primitive types.
>
> gdb/testsuite/ChangeLog:
>
>         * gdb.python/py-lookup-type.exp: New file.

Not that I'm expecting anyone to go back and change things,
but maybe for future reference it'd be better to print the result
and record the expected output, instead of expecting no output.
Performing a lookup action, and then expecting no output,
is just too confusing to me.