From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: pushed: FYI: [python/Ada] gdb.lookup_type fails to looking primitive type
Date: Mon, 26 Jan 2015 10:51:00 -0000 [thread overview]
Message-ID: <20150126044319.GA4697@adacore.com> (raw)
In-Reply-To: <CADPb22S2x9Bqtg8mtQ05uoKxos0Gj2-OOxf3qZDX8bP2PTstyA@mail.gmail.com>
> Ah, I didn't know you were waiting on me.
> I think printing the type name is just what was chosen at the time.
> That choice is fine by me fwiw.
>
> > gdb/ChangeLog:
> >
> > * gdb.python/py-lookup-type.exp (test_lookup_type): Change
> > the second test to print the name attribute of value
> > returned by the call to gdb.lookup_type, and adjust
> > the expected output accordingly.
> >
> > Tested on x86_64-linux.
> >
> > Does this change answer your concerns?
>
> There was no need to address anything, but thanks.
> I was just making a suggestion for the next time.
> [And I mean "suggestion" literally. 1/2 :-)]
>
> The patch is fine by me.
> Thanks again.
Thanks for the feedback. I pushed the patch to master.
--
Joel
prev parent reply other threads:[~2015-01-26 4:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 17:26 Joel Brobecker
2015-01-12 17:59 ` Doug Evans
2015-01-13 9:44 ` Joel Brobecker
2015-01-13 20:57 ` Doug Evans
2015-01-14 5:01 ` Joel Brobecker
2015-01-21 9:44 ` Joel Brobecker
2015-01-21 17:52 ` Doug Evans
2015-01-26 10:51 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126044319.GA4697@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox