Re: [PATCH 7/7] MIPS support

[Doug Evans <dje@google.com>]

Hi.  Just a nit.

On Fri, Jul 26, 2013 at 1:13 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> Support for the MIPS target.  MIPS already had a definition of
> gdbarch_gdb_signal_from_target, and also an enum containing all signal
> numbers from this target.  So, in order to make things standard, I
> removed the previous enum in favor of the new, difference-only enum
> declared by this patch series.  And I also redefined the implementation
> of gdbarch_gdb_signal_from_target for MIPS in order to take this new
> enum into account, and only handle the signals which are different from
> the Linux kernel generic ones.
>
> 2013-07-26  Sergio Durigan Junior  <sergiodj@redhat.com>
>
>         * mips-linux-tdep.c: Define enum with differences between
>         signals in MIPS and Linux kernel generic ones.
>         (mips_gdb_signal_to_target): New function.
>         (mips_gdb_signal_from_target): Redefine to use new enum, handle
>         only different signals from the Linux kernel generic.
>         (mips_linux_init_abi): Set gdbarch_gdb_signal_{to,from}_target
>         the functions defined above.
>         * mips_gdb_signal_to_target (enum mips_signals): Remove.

Nit: Fix changelog entry for mips-linux-tdep.h.