From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9958 invoked by alias); 27 Jul 2013 17:22:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9949 invoked by uid 89); 27 Jul 2013 17:22:28 -0000 X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO mail-ob0-f179.google.com) (209.85.214.179) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 27 Jul 2013 17:22:27 +0000 Received: by mail-ob0-f179.google.com with SMTP id xk17so6520555obc.38 for ; Sat, 27 Jul 2013 10:22:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=BlVBXx7RWrAI7UlXc/z/s9xr/GjxlpIDXUI4Zoe69Yo=; b=R015MxCpEb+qpAeO9IxWC6eqKnZYo/v5rNmZ+oepJ0Ugia6Rz2pukhmVqbrnYDX/LW 97+xGoYv5TQgsw84G+9MIwDP+c+z1VVK0C5pU7aYY5S1Hxo1BIucvO3eLEIPJOUQaYG6 yzhHvmJqcQBZFXGkMPG5D+u3+/inLDCB8ul3s0wFt69YPkDB1EPVHWfEmPUiifydIbUI XuYpNnQiCMFxcDJKJh1LOZd6t7Sw/saHnfK16r4YjFiIczp4WiyU23284s7h1orEyt77 pEiNzizDFWeelYvnjpQ0rm+KdLIOi2deKztbRnocEVW4g9tt51TjvwKMBjbtndOEBFxp 7mCg== MIME-Version: 1.0 X-Received: by 10.50.136.230 with SMTP id qd6mr356279igb.4.1374945739816; Sat, 27 Jul 2013 10:22:19 -0700 (PDT) Received: by 10.64.239.148 with HTTP; Sat, 27 Jul 2013 10:22:19 -0700 (PDT) In-Reply-To: <1374869594-16965-8-git-send-email-sergiodj@redhat.com> References: <1374869594-16965-1-git-send-email-sergiodj@redhat.com> <1374869594-16965-8-git-send-email-sergiodj@redhat.com> Date: Sat, 27 Jul 2013 17:22:00 -0000 Message-ID: Subject: Re: [PATCH 7/7] MIPS support From: Doug Evans To: Sergio Durigan Junior Cc: GDB Patches , Tom Tromey Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQn3wy914cfnnqLGCNSfeQgqyBne235/UMuEiAy+Sd75nAe/t0bVenTME7lxzA+3yglrUYKC5+AKGkejCCRa7fplsTXXnJmeWKX1w4i+c9QwDjCWqUYyWN3pCGMknpXqy4hj93hGolDK5QbR6Cx9St0v9aoGR7eoPi2L5zzDhk0jH0oeR80/ft69kj8kd4SzTQH8S6IQWXZJHKGEKM62bs9Fm8ze9A== X-SW-Source: 2013-07/txt/msg00663.txt.bz2 Hi. Just a nit. On Fri, Jul 26, 2013 at 1:13 PM, Sergio Durigan Junior wrote: > Support for the MIPS target. MIPS already had a definition of > gdbarch_gdb_signal_from_target, and also an enum containing all signal > numbers from this target. So, in order to make things standard, I > removed the previous enum in favor of the new, difference-only enum > declared by this patch series. And I also redefined the implementation > of gdbarch_gdb_signal_from_target for MIPS in order to take this new > enum into account, and only handle the signals which are different from > the Linux kernel generic ones. > > 2013-07-26 Sergio Durigan Junior > > * mips-linux-tdep.c: Define enum with differences between > signals in MIPS and Linux kernel generic ones. > (mips_gdb_signal_to_target): New function. > (mips_gdb_signal_from_target): Redefine to use new enum, handle > only different signals from the Linux kernel generic. > (mips_linux_init_abi): Set gdbarch_gdb_signal_{to,from}_target > the functions defined above. > * mips_gdb_signal_to_target (enum mips_signals): Remove. Nit: Fix changelog entry for mips-linux-tdep.h.