From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [3/10] introduce psymtab users
Date: Mon, 30 Apr 2012 18:52:00 -0000 [thread overview]
Message-ID: <CADPb22Sp5BieZsqgcRvcGzXU-gkX=PtB_PeOn+yL=uKjLTvFvw@mail.gmail.com> (raw)
In-Reply-To: <87haw7brks.fsf@fleche.redhat.com>
On Wed, Apr 25, 2012 at 11:21 AM, Tom Tromey <tromey@redhat.com> wrote:
> @@ -165,6 +169,11 @@ partial_map_symtabs_matching_filename (struct objfile *objfile,
>
> ALL_OBJFILE_PSYMTABS_REQUIRED (objfile, pst)
> {
> + /* We can skip shared psymtabs here, because any file name will be
> + attached to the unshared psymtab. */
> + if (pst->users != NULL)
> + continue;
> +
> if (FILENAME_CMP (name, pst->filename) == 0
> || (!is_abs && compare_filenames_for_search (pst->filename,
> name, name_len)))
The abstraction feels broken if ALL_OBJFILE_PSYMTABS* includes these
special shared psymtabs.
[This is akin to the objfile list including separate debug file objfiles.]
next prev parent reply other threads:[~2012-04-30 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 18:26 Tom Tromey
2012-04-26 18:01 ` Jan Kratochvil
2012-04-26 18:42 ` Tom Tromey
2012-04-26 18:48 ` Jan Kratochvil
2012-04-26 19:04 ` Tom Tromey
2012-04-27 10:14 ` Jan Kratochvil
2012-04-30 18:52 ` Doug Evans [this message]
2012-04-30 21:43 ` Doug Evans
2012-05-10 19:52 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22Sp5BieZsqgcRvcGzXU-gkX=PtB_PeOn+yL=uKjLTvFvw@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox