From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25419 invoked by alias); 30 Apr 2012 18:44:45 -0000 Received: (qmail 25411 invoked by uid 22791); 30 Apr 2012 18:44:44 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Apr 2012 18:44:30 +0000 Received: by vbbey12 with SMTP id ey12so2810621vbb.0 for ; Mon, 30 Apr 2012 11:44:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=L4vfEQZrOkVv3OYvpvrRKcOy/2q3rMkxskd2ckg2JnY=; b=lux+zBMnl8K8jy6dKoOeyEJ04Tp/OLFXmYh+8e6tckJVN+BrmqOqCx6ypdXF7qvQjc y9egN+71E/suTP7nBGR1X+xdYdB+3VjkJOshw+kupoxcaq1FPbAQVT8JPE4K3d5etL03 krL20eW8CvB9GGWZgGBFWpz9yWLdh8vcqSwNrK5cdUxik7HJDkRyNDCGEca+miAbDk21 LnP2+QmswSbtNBCfVfBJT21HwSSMWOEkVcODOVF8GSdM5ldvEm17d/TThoX9E/fucwA/ x/hrWcf3K5Y27rn4Ltkj/Hlb9PdqMGWWNeK3boerRXctKl/puD564gK0xaC6dfJUU76y OSZA== Received: by 10.220.151.71 with SMTP id b7mr1206559vcw.62.1335811470106; Mon, 30 Apr 2012 11:44:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.151.71 with SMTP id b7mr1206540vcw.62.1335811469834; Mon, 30 Apr 2012 11:44:29 -0700 (PDT) Received: by 10.52.165.2 with HTTP; Mon, 30 Apr 2012 11:44:29 -0700 (PDT) In-Reply-To: <87haw7brks.fsf@fleche.redhat.com> References: <87haw7brks.fsf@fleche.redhat.com> Date: Mon, 30 Apr 2012 18:52:00 -0000 Message-ID: Subject: Re: [3/10] introduce psymtab users From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQnfoAzTKcPIA1QN45X9yGL8cDyMN9pDnBK6xi1gKbO853TnSGGS88V5fTSs50Mo44B4uk4GC/qwnRjqaAqzO6quP1YRWU8ULg1vtZPR22HuKBZmSuDkV9jl/uYqEFYppxFYDJRnBvQ8M3EyQSSSyw0R/kZO1A== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg01085.txt.bz2 On Wed, Apr 25, 2012 at 11:21 AM, Tom Tromey wrote: > @@ -165,6 +169,11 @@ partial_map_symtabs_matching_filename (struct objfil= e *objfile, > > =A0 ALL_OBJFILE_PSYMTABS_REQUIRED (objfile, pst) > =A0 { > + =A0 =A0/* We can skip shared psymtabs here, because any file name will = be > + =A0 =A0 =A0 attached to the unshared psymtab. =A0*/ > + =A0 =A0if (pst->users !=3D NULL) > + =A0 =A0 =A0continue; > + > =A0 =A0 if (FILENAME_CMP (name, pst->filename) =3D=3D 0 > =A0 =A0 =A0 =A0|| (!is_abs && compare_filenames_for_search (pst->filename, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 name, name_len))) The abstraction feels broken if ALL_OBJFILE_PSYMTABS* includes these special shared psymtabs. [This is akin to the objfile list including separate debug file objfiles.]