From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org, Cary Coutant <ccoutant@google.com>,
Sterling Augustine <saugustine@google.com>
Subject: Re: FYI: fix latent bug in dw2_find_symbol_file
Date: Mon, 11 Jun 2012 21:26:00 -0000 [thread overview]
Message-ID: <CADPb22SdJWZLyyUOBvCBY-QR0f8XoXE3LrKzSzWsd4uYf82f0Q@mail.gmail.com> (raw)
In-Reply-To: <CADPb22Q=ScKSVNi=Yp-Pz-NFj3c7xkT+3N9Vkhva=f+7Zcz2tQ@mail.gmail.com>
On Mon, Jun 11, 2012 at 2:08 PM, Doug Evans <dje@google.com> wrote:
> On Mon, Jun 11, 2012 at 1:57 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>>
>> Doug> You need to call init_cutu_and_read_dies in both debug-types and
>> Doug> non-debug-types cases. When DWO files are in use DW_AT_name lives
>> Doug> in the DWO file. OTOH TUs typically don't have DW_AT_name (you
>> Doug> need to look at DW_AT_decl_file). OTOOH this function is only
>> Doug> called by find_main_filename.
>>
>> What gcc branch should I use to test this?
>> And do I need gold?
>>
>> Doug> I'm tempted to rename the routine {,*_}find_function_file (or some
>> Doug> such) and have dw2_find_symbol_file ignore TUs.
>>
>> Fine by me, but I don't plan to do it.
>
> Well, there's only 5 or so places you need to change for the renaming. :-)
>
> What I'm saying is the patch is wrong for TUs but TUs are irrelevant
> here anyway.
> What did you want to test?
Heh. Monday blues.
[The patch is also wrong for CUs.]
To test with DWO files you'll need a fission gcc+binutils.
I will let Sterling or Cary suggest what's the best to use.
next prev parent reply other threads:[~2012-06-11 21:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 18:42 Tom Tromey
2012-06-11 20:50 ` Doug Evans
2012-06-11 20:57 ` Tom Tromey
2012-06-11 21:08 ` Doug Evans
2012-06-11 21:26 ` Doug Evans [this message]
2012-06-13 22:10 ` Cary Coutant
2012-06-13 23:00 ` Tom Tromey
2012-06-12 15:40 ` Tom Tromey
2012-06-15 16:17 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22SdJWZLyyUOBvCBY-QR0f8XoXE3LrKzSzWsd4uYf82f0Q@mail.gmail.com \
--to=dje@google.com \
--cc=ccoutant@google.com \
--cc=gdb-patches@sourceware.org \
--cc=saugustine@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox