From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3085 invoked by alias); 11 Jun 2012 21:26:59 -0000 Received: (qmail 3074 invoked by uid 22791); 11 Jun 2012 21:26:58 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jun 2012 21:26:45 +0000 Received: by vbkv13 with SMTP id v13so2152633vbk.0 for ; Mon, 11 Jun 2012 14:26:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=YF8HLdoTL8JSpmhC/+7NX0pKjFLzWRxTYPYjOowQ8Y8=; b=DUTnZYmODEJrtWxZQHaabpNaV7EUcsf74sDoQCrhh4y9XRY/IZACuEuitLQc2inkrf lh75pR0ir+PN7Kh8Hn+ltwkyVbFu+2wG/Tqdgip4smrV9KIztdbtzwrcwnzxvzQa9cXJ bQVxLVdONGOQ8KgDFCR06guM2dWGM8kQkdsGKC7zPcNx7yj91VWkMj3CS6T/gG3rsUXJ iN2T2Nznih1TR8v5vfPD9D4lxC3EOZujOwQHnViaMUdrSwGocfJAuuYm+4trLsluj8Dr UMPvggqysrwA0Q9ufEEp9+QivP03wSd1GCYhz8tEEzILaYxQjZYLWcGtrp/EmTLTM5Tp IZ0g== Received: by 10.220.107.198 with SMTP id c6mr13528694vcp.54.1339450003831; Mon, 11 Jun 2012 14:26:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.107.198 with SMTP id c6mr13528681vcp.54.1339450003682; Mon, 11 Jun 2012 14:26:43 -0700 (PDT) Received: by 10.52.161.199 with HTTP; Mon, 11 Jun 2012 14:26:43 -0700 (PDT) In-Reply-To: References: <87d3558zcz.fsf@fleche.redhat.com> <87txyh7ejn.fsf@fleche.redhat.com> Date: Mon, 11 Jun 2012 21:26:00 -0000 Message-ID: Subject: Re: FYI: fix latent bug in dw2_find_symbol_file From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org, Cary Coutant , Sterling Augustine Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQlhgj9b0bXmy+CQpnovgyKLNBYNbxXRmtjQyCJbI2GA6f5kMeDu8Eu85T/zG0hSS31+fbtJyXfwu4iTs/KEdPBy5iVE0grtTqtecRTirR9c4GxqIchs0ndPpBVWGXYaBxt37N1DsSA78xdgsOZPvt4fV1+/6g== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00318.txt.bz2 On Mon, Jun 11, 2012 at 2:08 PM, Doug Evans wrote: > On Mon, Jun 11, 2012 at 1:57 PM, Tom Tromey wrote: >>>>>>> "Doug" =3D=3D Doug Evans writes: >> >> Doug> You need to call init_cutu_and_read_dies in both debug-types and >> Doug> non-debug-types cases. =A0When DWO files are in use DW_AT_name liv= es >> Doug> in the DWO file. =A0OTOH TUs typically don't have DW_AT_name (you >> Doug> need to look at DW_AT_decl_file). =A0OTOOH this function is only >> Doug> called by find_main_filename. >> >> What gcc branch should I use to test this? >> And do I need gold? >> >> Doug> I'm tempted to rename the routine {,*_}find_function_file (or some >> Doug> such) and have dw2_find_symbol_file ignore TUs. >> >> Fine by me, but I don't plan to do it. > > Well, there's only 5 or so places you need to change for the renaming. :-) > > What I'm saying is the patch is wrong for TUs but TUs are irrelevant > here anyway. > What did you want to test? Heh. Monday blues. [The patch is also wrong for CUs.] To test with DWO files you'll need a fission gcc+binutils. I will let Sterling or Cary suggest what's the best to use.