From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFC 1/8] Language independent bits
Date: Tue, 17 Jan 2012 16:44:00 -0000 [thread overview]
Message-ID: <CADPb22SWxRgTfw2dZbWFEtMeM_zxHrxNdJMsoFerjkREJJm7CA@mail.gmail.com> (raw)
In-Reply-To: <20120115203420.GA18901@host2.jankratochvil.net>
On Sun, Jan 15, 2012 at 12:34 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
>> +
>> + struct expression *expout;
>> +
>> + /* The size of the expression above. */
>> +
>> + int expout_size;
>
> Memory object size does not fit into `int', it should be `size_t'.
>
>
>> +
>> + /* The number of elements already in the expression. This is used
>> + to know where to put new elements. */
>> +
>> + int expout_ptr;
>
> Likewise.
Sure, but I think this is excessively nitpicky.
Each element is (at least) 16 bytes in size and gdb has been using
ints just fine so far.
next prev parent reply other threads:[~2012-01-17 16:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 18:51 [RFC 0/8] Beginning to remove globals from parser-defs.h Sergio Durigan Junior
2012-01-15 18:56 ` [RFC 1/8] Language independent bits Sergio Durigan Junior
2012-01-15 21:08 ` Jan Kratochvil
2012-01-15 21:17 ` Sergio Durigan Junior
2012-01-15 22:03 ` Jan Kratochvil
2012-01-16 12:32 ` Sergio Durigan Junior
2012-01-16 20:40 ` Tom Tromey
2012-01-16 19:39 ` Sergio Durigan Junior
2012-01-16 19:40 ` Jan Kratochvil
2012-01-16 20:27 ` Tom Tromey
2012-01-17 16:44 ` Doug Evans [this message]
2012-01-17 16:54 ` Jan Kratochvil
2012-01-15 19:01 ` [RFC 2/8] C language Sergio Durigan Junior
2012-01-16 19:29 ` Tom Tromey
2012-01-16 19:55 ` Sergio Durigan Junior
2012-01-18 11:38 ` Sergio Durigan Junior
2012-01-18 16:50 ` Tom Tromey
2012-01-15 19:04 ` [RFC 3/8] Ada language Sergio Durigan Junior
2012-01-15 19:05 ` [RFC 4/8] Fortran language Sergio Durigan Junior
2012-01-15 19:06 ` [RFC 5/8] Java language Sergio Durigan Junior
2012-01-15 19:07 ` [RFC 6/8] Modula-2 language Sergio Durigan Junior
2012-01-17 10:21 ` Gaius Mulley
2012-01-15 19:10 ` [RFC 7/8] Objective-C language Sergio Durigan Junior
2012-01-15 20:34 ` [RFC 8/8] Pascal language Sergio Durigan Junior
2012-01-16 19:29 ` Tom Tromey
2012-01-16 19:29 ` [RFC 0/8] Beginning to remove globals from parser-defs.h Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22SWxRgTfw2dZbWFEtMeM_zxHrxNdJMsoFerjkREJJm7CA@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox