From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6543 invoked by alias); 17 Jan 2012 16:34:23 -0000 Received: (qmail 6129 invoked by uid 22791); 17 Jan 2012 16:34:16 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Jan 2012 16:34:04 +0000 Received: by vcbfl11 with SMTP id fl11so400107vcb.0 for ; Tue, 17 Jan 2012 08:34:03 -0800 (PST) Received: by 10.221.13.135 with SMTP id pm7mr10709410vcb.51.1326818043276; Tue, 17 Jan 2012 08:34:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.221.13.135 with SMTP id pm7mr10709396vcb.51.1326818043177; Tue, 17 Jan 2012 08:34:03 -0800 (PST) Received: by 10.220.229.1 with HTTP; Tue, 17 Jan 2012 08:34:03 -0800 (PST) In-Reply-To: <20120115203420.GA18901@host2.jankratochvil.net> References: <20120115203420.GA18901@host2.jankratochvil.net> Date: Tue, 17 Jan 2012 16:44:00 -0000 Message-ID: Subject: Re: [RFC 1/8] Language independent bits From: Doug Evans To: Jan Kratochvil Cc: Sergio Durigan Junior , gdb-patches@sourceware.org X-System-Of-Record: true Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00602.txt.bz2 On Sun, Jan 15, 2012 at 12:34 PM, Jan Kratochvil wrote: >> + >> + =A0 =A0struct expression *expout; >> + >> + =A0 =A0/* The size of the expression above. =A0*/ >> + >> + =A0 =A0int expout_size; > > Memory object size does not fit into `int', it should be `size_t'. > > >> + >> + =A0 =A0/* The number of elements already in the expression. =A0This is= used >> + =A0 =A0 =A0 to know where to put new elements. =A0*/ >> + >> + =A0 =A0int expout_ptr; > > Likewise. Sure, but I think this is excessively nitpicky. Each element is (at least) 16 bytes in size and gdb has been using ints just fine so far.