Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	gdb-patches <gdb-patches@sourceware.org>,
		Tom Tromey <tromey@redhat.com>
Subject: Re: [RFC/Patch] Call overloaded operators to perform valid Python operations on struct/class values.
Date: Sat, 25 Jan 2014 18:45:00 -0000	[thread overview]
Message-ID: <CADPb22SK5ajRePCtPx1oELaCXi-vE=Pq8O4RR9zTVPmFkXeUQw@mail.gmail.com> (raw)
In-Reply-To: <CAGyQ6gy7-aJrDMHawSwKJ1km8nqy_7vsQtRUg=SZPCD=cT1osQ@mail.gmail.com>

On Wed, Jan 22, 2014 at 1:39 PM, Siva Chandra <sivachandra@google.com> wrote:
> ping.
>
> Any decision on this patch/feature?
>
>> 2013-12-30  Siva Chandra Reddy  <sivachandra@google.com>
>>
>>         Call overloaded operators to perform valid Python operations on
>>         struct/class values.
>>         * NEWS (Python Scripting): Add entry for this new feature.
>>         * python/py-value.c (valpy_binop): Call value_x_binop for struct
>>         and class values.
>>
>>         testsuite/
>>         * gdb.python/py-value-cc.cc: Improve test case to enable testing
>>         operations on gdb.Value objects.
>>         * gdb.python/py-value-cc.exp: Add new test to test operations on
>>         gdb.Value objects.
>>
>>         doc/
>>         * gdb.texinfo (Values From Inferior): Add description about
>>         performing valid Python operations on gdb.Value objects.

Hi.  Thanks for persevering.

Tom said it seems fine to him, and I've expressed my thoughts.

Seems like a green light to me.

IWBN if the docs listed exactly which operations are supported.
Ok with that change.
[I realize this patch relies on the user-defined method patch, so it
can't go in just yet.]

Thanks again for persevering.


      reply	other threads:[~2014-01-25 18:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 19:28 Siva Chandra
2013-12-06  6:25 ` Doug Evans
2013-12-06 14:20   ` Siva Chandra
2013-12-11 20:18     ` Tom Tromey
2013-12-11 20:17   ` Tom Tromey
2013-12-16  7:48     ` Doug Evans
2013-12-16 22:24       ` Siva Chandra
2013-12-18 16:37         ` Doug Evans
2013-12-18 23:15           ` Siva Chandra
2013-12-19 14:11             ` Doug Evans
2013-12-19 17:50               ` Siva Chandra
2013-12-20 22:29                 ` Siva Chandra
2013-12-21  8:21                   ` Eli Zaretskii
2013-12-30 14:40                     ` Siva Chandra
2013-12-30 17:57                       ` Eli Zaretskii
2014-01-22 21:39                       ` Siva Chandra
2014-01-25 18:45                         ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22SK5ajRePCtPx1oELaCXi-vE=Pq8O4RR9zTVPmFkXeUQw@mail.gmail.com' \
    --to=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=sivachandra@google.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox