Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] Rename "prettyprint" to "prettyformat"
Date: Tue, 09 Jul 2013 17:00:00 -0000	[thread overview]
Message-ID: <CADPb22SJ45s4+MLfudH_5B4i4xOx0XyLJT0sfGVRCXuzDi4_XA@mail.gmail.com> (raw)
In-Reply-To: <yjt2sizyat6k.fsf@ruffy.mtv.corp.google.com>

On Mon, Jul 1, 2013 at 2:04 PM, Doug Evans <dje@google.com> wrote:
> Hi.
> This patch is basically an internal renaming to remove some of the ambiguity in
> "pretty printing".
>
> The "prettyprinting" in struct value_print_options is now called
> "prettyformatting".  The rest of the patch is just fallout from that.
>
> Regression tested on amd64-linux.
>
> I will check this in in a few days if there are no objections.
>
> [I realize we had a discussion before about whether "All callers
> updated." applies to just the one file, or all files.
> There was no decision IIRC, and I prefer the simplicity of this way.]
>
> 2013-07-01  Doug Evans  <dje@google.com>
>
>         * defs.h (enum val_prettyformat): Renamed from val_prettyprint.
>         Enum values rename as well.  All uses updated.
>         * valprint.h (value_print_options): Rename member pretty to
>         pretty format.  Rename member prettyprint_arrays to
>         prettyformat_arrays.  Rename member prettyprint_structs to
>         prettyformat_structs.  All uses updated.
>         (get_no_prettyformat_print_options): Renamed from
>         get_raw_print_options.
>         * valprint.c (get_no_prettyformat_print_options): Renamed from
>         get_raw_print_options.  All callers updated.
>         (show_prettyformat_structs): Renamed from show_prettyprint_structs.
>         All callers updated.
>         (show_prettyformat_arrays): Renamed from show_prettyprint_arrays.
>         All callers updated.
>         (_initialize_valprint): Improve help text for "set print pretty" and
>         "set print arrays".
>
>         testsuite/
>         gdb.base/default.exp: Update expected output of "show print array"
>         and "show print pretty".

Committed.


  parent reply	other threads:[~2013-07-09 17:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01 21:04 Doug Evans
2013-07-01 21:22 ` Doug Evans
2013-07-09 17:00 ` Doug Evans [this message]
2013-07-10  3:18   ` [commit/obvious] Fix call to get_raw_print_options on mt-tdep.c (was: Re: [patch] Rename "prettyprint" to "prettyformat") Sergio Durigan Junior
2013-07-10  3:33     ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADPb22SJ45s4+MLfudH_5B4i4xOx0XyLJT0sfGVRCXuzDi4_XA@mail.gmail.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox