From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23878 invoked by alias); 9 Jul 2013 17:00:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23831 invoked by uid 89); 9 Jul 2013 17:00:44 -0000 X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-qe0-f45.google.com (HELO mail-qe0-f45.google.com) (209.85.128.45) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 09 Jul 2013 17:00:44 +0000 Received: by mail-qe0-f45.google.com with SMTP id w7so3145877qeb.32 for ; Tue, 09 Jul 2013 10:00:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:x-gm-message-state; bh=W3t9/XJPQiBb7EJDErWeCfBxv2ShRJFBcFxQAKvYtek=; b=YqLV8XEsModpn3t/Qpmd0N6+Tew7DxqBrr6a7FerwgIlNv3mLwwZ6iD2+72wRXe4mh yo1yivDZ9mbJvlZYBMtyKvPYVmJkPO8eqSSnkaFE1gQ1gD62l0f0wizt3GozmON3WefZ kXI+wAMCUPSSY46E2264F3o+gbr3kZzSQEkB7RA1oD3m/J06MLtE/NHN9Rdy9XJCWQsa wG2JJOKGJrm4MaVkaq8hQhZbGf7AeVUasUbEEcED+TUPZArZWdQBEycDQw6e/GZEdP2J xX9Nsqvuw7R9sT/e5XS4bOjsfvmt0T+js6Qgcu7yBy6FrdjmII1rQMf3MJFUeFZaa+uv vrmA== MIME-Version: 1.0 X-Received: by 10.224.25.140 with SMTP id z12mr23876901qab.46.1373389242266; Tue, 09 Jul 2013 10:00:42 -0700 (PDT) Received: by 10.229.118.199 with HTTP; Tue, 9 Jul 2013 10:00:42 -0700 (PDT) In-Reply-To: References: Date: Tue, 09 Jul 2013 17:00:00 -0000 Message-ID: Subject: Re: [patch] Rename "prettyprint" to "prettyformat" From: Doug Evans To: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnOuwWX/FCaottJLN3AwtLCtaBKRdvoMz/AlgIwIttuRvbSYmkhb0ZHFl9i4yTXh0K3nM4zg+LoypqCGUmNlUwIOWfgUH9mOmHS6av2iKGckr7Jp9IAg/VGMWxYbppSw/b7GUijh0mph9dJRRC4wWWRy3DFH8LNhSmj8+KjSLLZKUynbvLlYfQ6D41C90wIerwxMoTVntyjk7FIMUJRmGnpeSgfmg== X-SW-Source: 2013-07/txt/msg00250.txt.bz2 On Mon, Jul 1, 2013 at 2:04 PM, Doug Evans wrote: > Hi. > This patch is basically an internal renaming to remove some of the ambiguity in > "pretty printing". > > The "prettyprinting" in struct value_print_options is now called > "prettyformatting". The rest of the patch is just fallout from that. > > Regression tested on amd64-linux. > > I will check this in in a few days if there are no objections. > > [I realize we had a discussion before about whether "All callers > updated." applies to just the one file, or all files. > There was no decision IIRC, and I prefer the simplicity of this way.] > > 2013-07-01 Doug Evans > > * defs.h (enum val_prettyformat): Renamed from val_prettyprint. > Enum values rename as well. All uses updated. > * valprint.h (value_print_options): Rename member pretty to > pretty format. Rename member prettyprint_arrays to > prettyformat_arrays. Rename member prettyprint_structs to > prettyformat_structs. All uses updated. > (get_no_prettyformat_print_options): Renamed from > get_raw_print_options. > * valprint.c (get_no_prettyformat_print_options): Renamed from > get_raw_print_options. All callers updated. > (show_prettyformat_structs): Renamed from show_prettyprint_structs. > All callers updated. > (show_prettyformat_arrays): Renamed from show_prettyprint_arrays. > All callers updated. > (_initialize_valprint): Improve help text for "set print pretty" and > "set print arrays". > > testsuite/ > gdb.base/default.exp: Update expected output of "show print array" > and "show print pretty". Committed.