From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add function host_string_to_python_string.
Date: Wed, 30 Mar 2016 06:51:00 -0000 [thread overview]
Message-ID: <CADPb22RdeDO0LjBmD8d80QnPOjVvXC=GfAVKFA+jQ-E8DuuJDw@mail.gmail.com> (raw)
In-Reply-To: <567454ED.10204@redhat.com>
On Fri, Dec 18, 2015 at 10:48 AM, Pedro Alves <palves@redhat.com> wrote:
> On 12/18/2015 06:24 PM, Joel Brobecker wrote:
>>> There's a python_string_to_host_string function, but not its counterpart.
>>> I couldn't find anything in the record arguing against its existence,
>>> and there's enough of a use for it so I added it.
>>>
>>> Regression tested on amd64-linux.
>>>
>>> 2015-12-18 Doug Evans <dje@google.com>
>>>
>>> * python/py-utils.c (host_string_to_python_string): New function.
>>> * python/python-internal.h (host_string_to_python_string): Declare it.
>>> * python/py-*.c (*): Update all calls to
>>> PyString_Decode (str, strlen (str), host_charset (), NULL)
>>> to use host_string_to_python_string (str) instead.
>>
>> FWIW, looking at the alternative, I find the new one much better,
>> so that's a nice addition, IMO.
>
> Agreed.
Reapplied, reran testsuite, and committed.
prev parent reply other threads:[~2016-03-30 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 18:04 Doug Evans
2015-12-18 18:24 ` Joel Brobecker
2015-12-18 18:48 ` Pedro Alves
2016-03-30 6:51 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22RdeDO0LjBmD8d80QnPOjVvXC=GfAVKFA+jQ-E8DuuJDw@mail.gmail.com' \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox