From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62648 invoked by alias); 30 Mar 2016 06:51:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62638 invoked by uid 89); 30 Mar 2016 06:51:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*F:U*dje X-HELO: mail-vk0-f43.google.com Received: from mail-vk0-f43.google.com (HELO mail-vk0-f43.google.com) (209.85.213.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 30 Mar 2016 06:51:05 +0000 Received: by mail-vk0-f43.google.com with SMTP id e6so48991136vkh.2 for ; Tue, 29 Mar 2016 23:51:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dcBaL4fQ8uJqoIICT29jfosWt9vOv18DCo9tuc0H6ek=; b=InGCyxH0Kek3Gxc/LM7wKSDPjWAE4+fLAvtVtZnbRzeMf48DanDa+ZZJOsJqeAlX8I UInTj7dJkxUjRW2mx8UkVZLCRuH6ji0ZDD1+7OjtYgptvrUfa7KNxfts3xo/9s4GqVwk 71ZUu6QzCNnZqFoGcFt1pdcNZNLSartgjmYi8DJG4wknl3YqngE/o2jKwp6VDPQ9u4xt JTRj9vsNTP/YMrJgTKqHEIiTHbDVGa5UtGZvjZkWQ5dIwP5OiR3W7cNMtbUK5wzjiKyd cu7C5d9lyoz8QTVyGeXK1Ejph26RhpcgXWwh3Yx4kIUO8mhTvhK/wKPB7J0CpfQofXSL nlKw== X-Gm-Message-State: AD7BkJIxMQnAFrQrRmXWyTQZMC4hsqXxLdlWlHJmHKNZNMUrYsYqCNDuw128wdkmQ9+gknFBohqWnqD56XxzylDH X-Received: by 10.31.8.205 with SMTP id 196mr4192161vki.144.1459320663499; Tue, 29 Mar 2016 23:51:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.148.216 with HTTP; Tue, 29 Mar 2016 23:50:23 -0700 (PDT) In-Reply-To: <567454ED.10204@redhat.com> References: <001a11438f7c8987ea05272ff754@google.com> <20151218182436.GG29928@adacore.com> <567454ED.10204@redhat.com> From: Doug Evans Date: Wed, 30 Mar 2016 06:51:00 -0000 Message-ID: Subject: Re: [PATCH] Add function host_string_to_python_string. To: Pedro Alves Cc: Joel Brobecker , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00551.txt.bz2 On Fri, Dec 18, 2015 at 10:48 AM, Pedro Alves wrote: > On 12/18/2015 06:24 PM, Joel Brobecker wrote: >>> There's a python_string_to_host_string function, but not its counterpart. >>> I couldn't find anything in the record arguing against its existence, >>> and there's enough of a use for it so I added it. >>> >>> Regression tested on amd64-linux. >>> >>> 2015-12-18 Doug Evans >>> >>> * python/py-utils.c (host_string_to_python_string): New function. >>> * python/python-internal.h (host_string_to_python_string): Declare it. >>> * python/py-*.c (*): Update all calls to >>> PyString_Decode (str, strlen (str), host_charset (), NULL) >>> to use host_string_to_python_string (str) instead. >> >> FWIW, looking at the alternative, I find the new one much better, >> so that's a nice addition, IMO. > > Agreed. Reapplied, reran testsuite, and committed.