Re: [windows] patch to set breakpoint in a dll

[Doug Evans <dje@google.com>]

On Thu, Mar 15, 2012 at 6:52 PM, asmwarrior <asmwarrior@gmail.com> wrote:
> Ok, this is the new patch.(I have problem using the TortoiseGit to generate
> a diff between two revisions.you can see, the file name is long and dirty)
>
>
> Also, the log message is what you wrote:
>
>
> 2012-03-14  Zhang Yuanhui <asmwarrior@gmail.com>
>
>    * source.c (find_and_open_source): Consistently pass resulting
>    full path through xfullpath.
>
>
> My family name is "Zhang", so I'm not sure it should be put before the given
> name or after the given name. The Chinese name and English name have
> different formats.

I say it's your choice.  I just copied from an existing example in ChangeLog.

Heh.  One last nit.  Blank line between these two lines.

+       char *lpath;
+       lpath = xfullpath (*fullname);

[or combine them, but then you still need a blank line afterwards]

Can you check the patch in?  I'm happy to for you if necessary (at
which point I can just insert the blank line before checkin).