From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6670 invoked by alias); 16 Mar 2012 22:23:31 -0000 Received: (qmail 6660 invoked by uid 22791); 16 Mar 2012 22:23:29 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,TW_SM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Mar 2012 22:23:16 +0000 Received: by vcbfk14 with SMTP id fk14so6063131vcb.0 for ; Fri, 16 Mar 2012 15:23:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=pINULnAUJoquehPu7zCNLYOXN7CVZRh87dP8FzwMufM=; b=D088xl2EjJ/0JknW9Dc4ftruoEUXtondagE3fomJqqn6kPU7eSH0gseF7qYDfsDR1V RaBd4oNGMDKFcsmyLHX34QnIL08TJ13ukB4Lh1KaKNUAndEx+k/FOPih6uaX1LwyUwoT kcm6Nzo4I/uhJwEkaTppEOsgsqOx8CXfucyyGR0m3/pLG8gxOd3XNb4h2CwTc6FXbstG 0MAdBA/JFN8fldFkK9od5xTNHS/XPvVUFsHTlR4Uq4Mt1vbARtuVwAiULksfibZiIqLS l4W5vFyf7XA29I8bLvIDUPdfhfi39w0bVPUL0EFruSbh0Ccv39x020gxgtzDbdagzMJW cscQ== Received: by 10.52.34.212 with SMTP id b20mr2168579vdj.3.1331936595694; Fri, 16 Mar 2012 15:23:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.34.212 with SMTP id b20mr2168573vdj.3.1331936595605; Fri, 16 Mar 2012 15:23:15 -0700 (PDT) Received: by 10.220.187.12 with HTTP; Fri, 16 Mar 2012 15:23:15 -0700 (PDT) In-Reply-To: <4F629CE5.8030301@gmail.com> References: <4F54D758.8020508@gmail.com> <4F5816EE.4050908@gmail.com> <20120314182606.F20822461B2@ruffy.mtv.corp.google.com> <4F629CE5.8030301@gmail.com> Date: Fri, 16 Mar 2012 22:23:00 -0000 Message-ID: Subject: Re: [windows] patch to set breakpoint in a dll From: Doug Evans To: asmwarrior Cc: gdb-patches@sourceware.org, Chris Sutcliffe Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQlfV+IgVdEcI6tY0qKV4PL3cnJU7pDfi0JBULeawdO0QJxocQfntPXeJswoVrd9k12noWVxGa1Dx3Zqktp3k0vD95DKyGWnBHNDcI7nnzb7lLkU9hj01/IMm3h3cR95G915sOSQgNWzlV+gkHTsQxqmWtwCZg== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00639.txt.bz2 On Thu, Mar 15, 2012 at 6:52 PM, asmwarrior wrote: > Ok, this is the new patch.(I have problem using the TortoiseGit to genera= te > a diff between two revisions.you can see, the file name is long and dirty) > > > Also, the log message is what you wrote: > > > 2012-03-14 =A0Zhang Yuanhui > > =A0 =A0* source.c (find_and_open_source): Consistently pass resulting > =A0 =A0full path through xfullpath. > > > My family name is "Zhang", so I'm not sure it should be put before the gi= ven > name or after the given name. The Chinese name and English name have > different formats. I say it's your choice. I just copied from an existing example in ChangeLo= g. Heh. One last nit. Blank line between these two lines. + char *lpath; + lpath =3D xfullpath (*fullname); [or combine them, but then you still need a blank line afterwards] Can you check the patch in? I'm happy to for you if necessary (at which point I can just insert the blank line before checkin).