From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] breakpoint always inserted in record target
Date: Thu, 12 Apr 2012 19:40:00 -0000 [thread overview]
Message-ID: <CADPb22RDU=qGC5vG+DhZDB9GbDUA7dDWDs9jxMghr7qUu-AaVw@mail.gmail.com> (raw)
In-Reply-To: <4F866526.8070100@codesourcery.com>
On Wed, Apr 11, 2012 at 10:16 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 04/12/2012 12:45 PM, Doug Evans wrote:
>> Plus, can you write a testcase?
>
> In existing test cases in gdb.reverse, breakpoints are inserted into
> inferior. Without this patch, when run gdb.reverse/i386-sse-reverse.exp
> (turning on always inserted mode), we get a lot fails. When this patch
> applied, fails go away. I think this patch is exercised by this case.
> I should mention this fixed fails in my patch post.
>
> What do you want to test beyond my description above?
No that's sufficient.
I don't want to unnecessarily expand the scope of your patch.
[for reference sake]
IWBN if we didn't have to run the testsuite in multiple ways as much
as we do now.
next prev parent reply other threads:[~2012-04-12 19:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 13:16 Yao Qi
2012-04-11 18:15 ` Keith Seitz
2012-04-13 2:03 ` Yao Qi
2012-04-13 9:47 ` Eli Zaretskii
2012-04-13 16:00 ` Pedro Alves
2012-04-23 6:57 ` Yao Qi
2012-04-24 13:18 ` Pedro Alves
2012-04-24 15:00 ` [committed]: " Yao Qi
2012-04-12 5:16 ` Doug Evans
2012-04-12 5:33 ` Yao Qi
2012-04-12 19:40 ` Doug Evans [this message]
2012-04-12 20:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22RDU=qGC5vG+DhZDB9GbDUA7dDWDs9jxMghr7qUu-AaVw@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox