From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19640 invoked by alias); 12 Apr 2012 19:39:51 -0000 Received: (qmail 19630 invoked by uid 22791); 12 Apr 2012 19:39:50 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Apr 2012 19:39:37 +0000 Received: by vbbey12 with SMTP id ey12so2015845vbb.0 for ; Thu, 12 Apr 2012 12:39:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=OYaV4g7vjtuZLSuuVSxza80lkH+umnEHZJu0Fyoqlq8=; b=X5aQR5IQaRv+pO9NuNWYxQ2MjCFTXVmqFblllwiXG6j6tcMgToueQUQkuiWpoH+CH+ 8rFHljYZp9bHgCnOAdTMHEVf7ko4SFzZO4FWnvdoIrk5BQx68DtSjfZWAnEw8HMhBefB RdNTZlx4IAsagcvB39lTUgALyrPElhgBZjdgC9QDfBVvMmIGdGAXTn8OtVcWy7T0ouSU v6RR7ln4Lyaox1XRaFpSlWzNizOEvPynZraKmGnsyiheLoj5okmSsT7+bqjEGdWGmPzc hs/VcJNPmxeEMt3oxiePuVQAY2g0A9oGNMEy+rf/uo+W3YpcXLXlT/MfNRrbbJKeGgVR 7BFQ== Received: by 10.52.93.131 with SMTP id cu3mr1483285vdb.122.1334259577149; Thu, 12 Apr 2012 12:39:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.93.131 with SMTP id cu3mr1483279vdb.122.1334259577010; Thu, 12 Apr 2012 12:39:37 -0700 (PDT) Received: by 10.220.7.74 with HTTP; Thu, 12 Apr 2012 12:39:36 -0700 (PDT) In-Reply-To: <4F866526.8070100@codesourcery.com> References: <1334149619-2738-1-git-send-email-yao@codesourcery.com> <4F866526.8070100@codesourcery.com> Date: Thu, 12 Apr 2012 19:40:00 -0000 Message-ID: Subject: Re: [PATCH] breakpoint always inserted in record target From: Doug Evans To: Yao Qi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQksT9pQ4ykkiyDPLfiDlJ2sVryZTv+EZ8+GCqjf8cqSoTYR1K07ckm75BD+oghGNUd0EIoPc6s52JEhnwbcN/xmHp4fWjuLwHUBfgBkx83+KK+f6dD2beo+CLGRwM2HGG8UzsgttOzbUuLfErN6xJCVVr2Gdw== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00319.txt.bz2 On Wed, Apr 11, 2012 at 10:16 PM, Yao Qi wrote: > On 04/12/2012 12:45 PM, Doug Evans wrote: >> Plus, can you write a testcase? > > In existing test cases in gdb.reverse, breakpoints are inserted into > inferior. =A0Without this patch, when run gdb.reverse/i386-sse-reverse.exp > (turning on always inserted mode), we get a lot fails. =A0When this patch > applied, fails go away. =A0I think this patch is exercised by this case. > I should mention this fixed fails in my patch post. > > What do you want to test beyond my description above? No that's sufficient. I don't want to unnecessarily expand the scope of your patch. [for reference sake] IWBN if we didn't have to run the testsuite in multiple ways as much as we do now.