Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add tab completion for TUI's "focus" command
Date: Wed, 24 Jun 2015 14:35:00 -0000	[thread overview]
Message-ID: <CADPb22RBTuT9Rf4Tt_L0KYPgJ7aY0zOPbrotnV95sAExus=sOQ@mail.gmail.com> (raw)
In-Reply-To: <1435073391-18518-1-git-send-email-patrick@parcs.ath.cx>

On Tue, Jun 23, 2015 at 10:29 AM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> The implementation is pretty straightforward, with the only caveat being
> that the "src", "cmd", "next" and "prev" entries get delibrately added
> to the completion list even when the TUI has not yet been initialized
> (i.e. has never been enabled during the session), since invoking the
> "focus" command with these arguments already works when the TUI has not
> yet been initialized.
>
> gdb/ChangeLog:
>
>         * tui/tui-win.c (focus_completer): New static function.
>         (_initialize_tui_win): Set the completion function of the
>         "focus" command to focus_completer.
>
> gdb/testsuite/ChangeLog:
>
>         * gdb.base/completion.exp: Test the completion of the "focus"
>         command.

LGTM


      reply	other threads:[~2015-06-24 14:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22  3:30 Patrick Palka
2015-06-23 14:01 ` Doug Evans
2015-06-23 14:37   ` Patrick Palka
2015-06-23 14:54     ` Doug Evans
2015-06-23 16:52       ` Pedro Alves
2015-06-23 15:30 ` Patrick Palka
2015-06-24 14:35   ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22RBTuT9Rf4Tt_L0KYPgJ7aY0zOPbrotnV95sAExus=sOQ@mail.gmail.com' \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=patrick@parcs.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox