From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20653 invoked by alias); 24 Jun 2015 14:35:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20640 invoked by uid 89); 24 Jun 2015 14:35:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f173.google.com Received: from mail-ob0-f173.google.com (HELO mail-ob0-f173.google.com) (209.85.214.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 24 Jun 2015 14:35:57 +0000 Received: by obbkm3 with SMTP id km3so27917918obb.1 for ; Wed, 24 Jun 2015 07:35:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=7Ba4p6Grs8uJVNIiYVZA1Qx9pkck5M+XoRdvNX0HdGg=; b=b1ZkB385efNKK9LuU4lox6wcIhF/xWxdi6nzvO64HN+iVdNInlKZfsOGBQcgPgRdNd 7ebyYG112ANkFej/ZOzKrAb+luT0S5oq2o9gJomnzOpwWwhRB3fH7u9Nxutoy47Nwij6 9NFaM+CghKFNneFSv/IPnu+WoidcQMH4AKnr0JJeLYdrYE8LXzn2xInN2rttKDsa3DK2 NHh8wDbMtGqwuDGDl5P6hu2r4XKGEI3tOkZTTL3si39hYnakjZqzdwvjC3AOR8VSYUiT bbdzCMbWTmOWNQCkvg1I74hjMcKXoaRvKjIkLyP9E4ECWFuYMn11XkOmqjsY7rpiWkl7 Iqig== X-Gm-Message-State: ALoCoQklPIgfByEQWIXTqDj4SJFpZzVGIQAjyC1F2EjH8CJBsAk9T8cV+hbFt2//kpT9nl22iG3R X-Received: by 10.202.80.204 with SMTP id e195mr33129694oib.116.1435156555311; Wed, 24 Jun 2015 07:35:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.89.99 with HTTP; Wed, 24 Jun 2015 07:35:15 -0700 (PDT) In-Reply-To: <1435073391-18518-1-git-send-email-patrick@parcs.ath.cx> References: <1434943800-9274-1-git-send-email-patrick@parcs.ath.cx> <1435073391-18518-1-git-send-email-patrick@parcs.ath.cx> From: Doug Evans Date: Wed, 24 Jun 2015 14:35:00 -0000 Message-ID: Subject: Re: [PATCH] Add tab completion for TUI's "focus" command To: Patrick Palka Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00532.txt.bz2 On Tue, Jun 23, 2015 at 10:29 AM, Patrick Palka wrote: > The implementation is pretty straightforward, with the only caveat being > that the "src", "cmd", "next" and "prev" entries get delibrately added > to the completion list even when the TUI has not yet been initialized > (i.e. has never been enabled during the session), since invoking the > "focus" command with these arguments already works when the TUI has not > yet been initialized. > > gdb/ChangeLog: > > * tui/tui-win.c (focus_completer): New static function. > (_initialize_tui_win): Set the completion function of the > "focus" command to focus_completer. > > gdb/testsuite/ChangeLog: > > * gdb.base/completion.exp: Test the completion of the "focus" > command. LGTM