Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [RFA] Don't immediately SIGTERM the child of "target remote |".
Date: Thu, 01 Dec 2011 20:13:00 -0000	[thread overview]
Message-ID: <CADPb22R6gCdKtGficCvs-6QdUAtXC4tiK6Wha3MdfG0nMH=Qpg@mail.gmail.com> (raw)
In-Reply-To: <20111201194954.GA13230@host2.jankratochvil.net>

On Thu, Dec 1, 2011 at 11:49 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Thu, 01 Dec 2011 20:46:35 +0100, Doug Evans wrote:
>> +extern int wait_to_die_with_timeout (int pid, int *status, int timeout);
>                                        pid_t pid
> just a nitpick

I thought of that but punted on portability grounds.
There are lots of places in gdb that still use int.

It *would* be preferable.
And the code does live inside #ifdef HAVE_WAITPID.


  reply	other threads:[~2011-12-01 20:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-24  0:01 [RFC] " Doug Evans
2011-11-24  0:09 ` Doug Evans
2011-11-24  3:57 ` Eli Zaretskii
2011-11-24  6:20   ` Doug Evans
2011-11-27 20:40 ` Jan Kratochvil
2011-11-27 22:23   ` Doug Evans
2011-12-01 19:46     ` [RFA] " Doug Evans
2011-12-01 19:50       ` Jan Kratochvil
2011-12-01 20:13         ` Doug Evans [this message]
2011-12-01 20:20           ` Jan Kratochvil
2011-12-14 21:17             ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22R6gCdKtGficCvs-6QdUAtXC4tiK6Wha3MdfG0nMH=Qpg@mail.gmail.com' \
    --to=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox