From: Doug Evans <dje@google.com>
To: Matt Rice <ratmice@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] python testsuite disappearing py-objfile-script-gdb.py
Date: Wed, 13 Jul 2011 16:27:00 -0000 [thread overview]
Message-ID: <CADPb22Qz4mMWkV8ff4YMNtYitoapU_+pMkz2FbU4EEWesH+J5Q@mail.gmail.com> (raw)
In-Reply-To: <CACTLOFrfkcbiELm=zLE9gusZJXUaJMtrrwgJhUXRKVGK04oonQ@mail.gmail.com>
On Wed, Jul 6, 2011 at 7:06 PM, Matt Rice <ratmice@gmail.com> wrote:
> this fixes that py-objfile-script-gdb.py disappears when running the
> testsuite with an
> in-tree build.
>
> had to rename the source file, since the auto-loading API is expecting
> the destination
> file to use the current name.
>
> I'd also tried special casing the
> remote_file host delete ${remote_python_file}
>
> but couldn't figure out some dejagnu equivalent of if is_remote ||
> (!is_remote && ${srcdir} == ".")
> that special casing leaves it attempting to copy the file onto itself,
> but dejagnu
> seems to silently ignore that error.
>
> The file hasn't been modified since its initial commit, so we aren't
> losing a bunch of history,
> just the reference to the atomic commit/other files it was first added with.
>
> 2011-07-06 Matt Rice <ratmice@gmail.com>
>
> * gdb.python/py-objfile-script-gdb.py: Renamed to
> py-objfile-script-gdb.py.in.
> * gdb.python/py-objfile-script-gdb.py.in: Renamed from
> py-objfile-script-gdb.py.
> * gdb.python/py-objfile-script.exp: Update reference to
> py-objfile-script-gdb.py.
ok with me.
Thanks for doing it.
Nit: I think there's no need to have two ChangeLog entries to rename a file.
But no matter.
next prev parent reply other threads:[~2011-07-13 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 2:07 Matt Rice
2011-07-13 16:27 ` Doug Evans [this message]
2011-07-13 17:45 ` Matt Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22Qz4mMWkV8ff4YMNtYitoapU_+pMkz2FbU4EEWesH+J5Q@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=ratmice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox