From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20547 invoked by alias); 13 Jul 2011 15:58:21 -0000 Received: (qmail 20529 invoked by uid 22791); 13 Jul 2011 15:58:19 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jul 2011 15:57:49 +0000 Received: from wpaz33.hot.corp.google.com (wpaz33.hot.corp.google.com [172.24.198.97]) by smtp-out.google.com with ESMTP id p6DFvlDF031853 for ; Wed, 13 Jul 2011 08:57:47 -0700 Received: from gwb19 (gwb19.prod.google.com [10.200.2.19]) by wpaz33.hot.corp.google.com with ESMTP id p6DFuqbU012442 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT) for ; Wed, 13 Jul 2011 08:57:46 -0700 Received: by gwb19 with SMTP id 19so2886834gwb.4 for ; Wed, 13 Jul 2011 08:57:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.91.208.35 with SMTP id k35mr634139agq.207.1310572665762; Wed, 13 Jul 2011 08:57:45 -0700 (PDT) Received: by 10.90.8.9 with HTTP; Wed, 13 Jul 2011 08:57:45 -0700 (PDT) In-Reply-To: References: Date: Wed, 13 Jul 2011 16:27:00 -0000 Message-ID: Subject: Re: [patch] python testsuite disappearing py-objfile-script-gdb.py From: Doug Evans To: Matt Rice Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00348.txt.bz2 On Wed, Jul 6, 2011 at 7:06 PM, Matt Rice wrote: > this fixes that py-objfile-script-gdb.py disappears when running the > testsuite with an > in-tree build. > > had to rename the source file, since the auto-loading API is expecting > the destination > file to use the current name. > > I'd also tried special casing the > remote_file host delete ${remote_python_file} > > but couldn't figure out some dejagnu equivalent of if is_remote || > (!is_remote && ${srcdir} =3D=3D ".") > that special casing leaves it attempting to copy the file onto itself, > but dejagnu > seems to silently ignore that error. > > The file hasn't been modified since its initial commit, so we aren't > losing a bunch of history, > just the reference to the atomic commit/other files it was first added wi= th. > > 2011-07-06 =A0Matt Rice > > =A0 =A0 =A0 =A0* gdb.python/py-objfile-script-gdb.py: Renamed to > =A0 =A0 =A0 =A0py-objfile-script-gdb.py.in. > =A0 =A0 =A0 =A0* gdb.python/py-objfile-script-gdb.py.in: Renamed from > =A0 =A0 =A0 =A0py-objfile-script-gdb.py. > =A0 =A0 =A0 =A0* gdb.python/py-objfile-script.exp: Update reference to > =A0 =A0 =A0 =A0py-objfile-script-gdb.py. ok with me. Thanks for doing it. Nit: I think there's no need to have two ChangeLog entries to rename a file. But no matter.