Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: RE: New ARI warning Wed May 23 01:55:03 UTC 2012
Date: Wed, 23 May 2012 14:46:00 -0000	[thread overview]
Message-ID: <CADPb22Qi0Zda439aieEGu26+GWf0y8XzBUkcpg-Kw1BUcjvPNA@mail.gmail.com> (raw)
In-Reply-To: <4fbc9d77.0853b40a.641e.ffff90dbSMTPIN_ADDED@mx.google.com>

On May 23, 2012 1:19 AM, "Pierre Muller"
<pierre.muller@ics-cnrs.unistra.fr> wrote:
>
>  As a possible ARI maintainer I would like to clarify
> things here:
>  "long long" and "unsigned long long"
> are used in lots of native files, and they are
> OK in those context.
>
>  In fact, one of the improvements I have in mind is
> to restrain some ARI rules, like this one to
> GDB common files.
>  This would mean that files that are
> only used for specific native targets would be allowed to use
> "long long" without generating a warning.

I'm not comfortable with such rules, fwiw.
It's just more arcane baggage to have to remember and follow.

>
>  The use of "long long" and "unsigned long long"
> is discouraged as it is not available in all C compilers
> if I understood the definitions in defs.h around line 112.

I wonder how old that is.

>  Another possible use of LONGEST and ULONGEST
> is also to be able to cope with 128-bit integers if these
> are used in GDB later.

Think bigger.
LONGEST,ULONGEST are gdb-specific, and there is nothing in reading
leb128 values that is gdb-specific.

Plus a lot of code uses them with the assumption that they're 64 bits,
having them be 128 bits is probably not workable.

We've been debating whether to move to C++, and yet we can't even move
to C99. :-(


  parent reply	other threads:[~2012-05-23 14:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23  1:55 GDB Administrator
2012-05-23  4:18 ` Sergio Durigan Junior
2012-05-23  7:10   ` Doug Evans
2012-05-23  7:27     ` Doug Evans
2012-05-23  8:19       ` Pierre Muller
2012-05-23 14:45       ` Sergio Durigan Junior
     [not found]       ` <4fbc9d77.0853b40a.641e.ffff90dbSMTPIN_ADDED@mx.google.com>
2012-05-23 14:46         ` Doug Evans [this message]
2012-05-23 15:01           ` Doug Evans
2012-05-23 15:27             ` Pedro Alves
2012-05-24 18:55           ` Tom Tromey
2012-05-28 20:44             ` Mark Kettenis
2012-05-28 21:59               ` Joel Brobecker
2012-05-29 13:29               ` Maciej W. Rozycki
2012-06-22 16:05               ` Tom Tromey
2012-06-22 17:19                 ` Joel Brobecker
2012-06-22 17:31                   ` Joel Brobecker
2012-06-22 17:41                     ` Tom Tromey
2012-06-22 19:02                       ` Joel Brobecker
2012-06-25 19:59                         ` Doug Evans
2012-06-26 13:31                         ` Mark Kettenis
2012-06-26 13:15                   ` Mark Kettenis
2012-06-26 11:51                 ` Mark Kettenis
2012-05-23  7:10   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADPb22Qi0Zda439aieEGu26+GWf0y8XzBUkcpg-Kw1BUcjvPNA@mail.gmail.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox